fix!: Wrap injected code in block-statement to contain scope #646

timfish · 2025-01-07T13:06:45Z

Closes Injected global variable _global can clash with user code #645

lforst

Would it maybe be enough to just wrap the snippet in {...}. May save some bytes.

timfish · 2025-01-07T13:11:21Z

Would it maybe be enough to just wrap the snippet in {...}. May save some bytes.

That doesn't work with var because of scoping rules. We would need to use let or const in this case.

timfish · 2025-01-07T13:14:56Z

packages/bundler-plugin-core/src/utils.ts

@@ -344,7 +346,7 @@ export function generateModuleMetadataInjectorCode(metadata: any) {
  // The checks are to support as many environments as possible. (Node.js, Browser, webworkers, etc.)
  // We are merging the metadata objects in case modules are bundled twice with the plugin
  return `{
-  var _sentryModuleMetadataGlobal =
+  const _sentryModuleMetadataGlobal =


I updated this too because block scoping rules for var mean that it wasn't working as expected

I am all for this but wondering whether we should cut a major in case somebody uses the bundler plugins for apps in an env where const isn't a thing yet.

I don't mind which way we go but we should either:

Use var and wrap in self-invoking function

Use var and wrap in try/catch

Use block-statement with const or let

made more changes

@jdelStrother

| datasource | package | from | to | | ---------- | ------------------- | ------ | ----- | | npm | @sentry/vite-plugin | 2.23.0 | 3.0.0 | ## [v3.0.0](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#300) ##### Breaking Changes - Injected code will now use `let`, which was added in ES6 (ES2015). This means that ES6 is the minimum JavaScript version that the Sentry bundler plugins support. - Deprecated options have been removed: - `deleteFilesAfterUpload` - Use `filesToDeleteAfterUpload` instead - `bundleSizeOptimizations.excludePerformanceMonitoring` - Use `bundleSizeOptimizations.excludeTracing` instead - `_experiments.moduleMetadata` - Use `moduleMetadata` instead - `cleanArtifacts` - Did not do anything ##### List of Changes - fix!: Wrap injected code in block-statement to contain scope ([#646](getsentry/sentry-javascript-bundler-plugins#646)) - chore!: Remove deprecated options ([#654](getsentry/sentry-javascript-bundler-plugins#654)) - feat(logger): Use console methods respective to log level ([#652](getsentry/sentry-javascript-bundler-plugins#652)) - fix(webpack): Ensure process exits when done ([#653](getsentry/sentry-javascript-bundler-plugins#653)) - fix: Use correct replacement matcher for `bundleSizeOptimizations.excludeTracing` ([#644](getsentry/sentry-javascript-bundler-plugins#644)) Work in this release contributed by [@jdelStrother](https://github.com/jdelStrother). Thank you for your contribution!

@jdelStrother

| datasource | package | from | to | | ---------- | ------------------- | ------ | ----- | | npm | @sentry/vite-plugin | 2.23.0 | 3.0.0 | ## [v3.0.0](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#300) ##### Breaking Changes - Injected code will now use `let`, which was added in ES6 (ES2015). This means that ES6 is the minimum JavaScript version that the Sentry bundler plugins support. - Deprecated options have been removed: - `deleteFilesAfterUpload` - Use `filesToDeleteAfterUpload` instead - `bundleSizeOptimizations.excludePerformanceMonitoring` - Use `bundleSizeOptimizations.excludeTracing` instead - `_experiments.moduleMetadata` - Use `moduleMetadata` instead - `cleanArtifacts` - Did not do anything ##### List of Changes - fix!: Wrap injected code in block-statement to contain scope ([#646](getsentry/sentry-javascript-bundler-plugins#646)) - chore!: Remove deprecated options ([#654](getsentry/sentry-javascript-bundler-plugins#654)) - feat(logger): Use console methods respective to log level ([#652](getsentry/sentry-javascript-bundler-plugins#652)) - fix(webpack): Ensure process exits when done ([#653](getsentry/sentry-javascript-bundler-plugins#653)) - fix: Use correct replacement matcher for `bundleSizeOptimizations.excludeTracing` ([#644](getsentry/sentry-javascript-bundler-plugins#644)) Work in this release contributed by [@jdelStrother](https://github.com/jdelStrother). Thank you for your contribution!

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@sentry/vite-plugin](https://github.com/getsentry/sentry-javascript-bundler-plugins/tree/main/packages/vite-plugin) ([source](https://github.com/getsentry/sentry-javascript-bundler-plugins)) | devDependencies | major | [`2.23.0` -> `3.0.0`](https://renovatebot.com/diffs/npm/@sentry%2fvite-plugin/2.23.0/3.0.0) | --- ### Release Notes <details> <summary>getsentry/sentry-javascript-bundler-plugins (@sentry/vite-plugin)</summary> ### [`v3.0.0`](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#300) [Compare Source](getsentry/sentry-javascript-bundler-plugins@2.23.0...3.0.0) ##### Breaking Changes - Injected code will now use `let`, which was added in ES6 (ES2015). This means that ES6 is the minimum JavaScript version that the Sentry bundler plugins support. - Deprecated options have been removed: - `deleteFilesAfterUpload` - Use `filesToDeleteAfterUpload` instead - `bundleSizeOptimizations.excludePerformanceMonitoring` - Use `bundleSizeOptimizations.excludeTracing` instead - `_experiments.moduleMetadata` - Use `moduleMetadata` instead - `cleanArtifacts` - Did not do anything ##### List of Changes - fix!: Wrap injected code in block-statement to contain scope ([#646](getsentry/sentry-javascript-bundler-plugins#646)) - chore!: Remove deprecated options ([#654](getsentry/sentry-javascript-bundler-plugins#654)) - feat(logger): Use console methods respective to log level ([#652](getsentry/sentry-javascript-bundler-plugins#652)) - fix(webpack): Ensure process exits when done ([#653](getsentry/sentry-javascript-bundler-plugins#653)) - fix: Use correct replacement matcher for `bundleSizeOptimizations.excludeTracing` ([#644](getsentry/sentry-javascript-bundler-plugins#644)) Work in this release contributed by [@jdelStrother](https://github.com/jdelStrother). Thank you for your contribution! </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://git.tristess.app/alexandresoro/ouca-web/pulls/21 Reviewed-by: Alexandre Soro <[email protected]> Co-authored-by: renovate <[email protected]> Co-committed-by: renovate <[email protected]>

@jdelStrother

| datasource | package | from | to | | ---------- | ------------------- | ------ | ----- | | npm | @sentry/vite-plugin | 2.23.0 | 3.0.0 | ## [v3.0.0](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#300) ##### Breaking Changes - Injected code will now use `let`, which was added in ES6 (ES2015). This means that ES6 is the minimum JavaScript version that the Sentry bundler plugins support. - Deprecated options have been removed: - `deleteFilesAfterUpload` - Use `filesToDeleteAfterUpload` instead - `bundleSizeOptimizations.excludePerformanceMonitoring` - Use `bundleSizeOptimizations.excludeTracing` instead - `_experiments.moduleMetadata` - Use `moduleMetadata` instead - `cleanArtifacts` - Did not do anything ##### List of Changes - fix!: Wrap injected code in block-statement to contain scope ([#646](getsentry/sentry-javascript-bundler-plugins#646)) - chore!: Remove deprecated options ([#654](getsentry/sentry-javascript-bundler-plugins#654)) - feat(logger): Use console methods respective to log level ([#652](getsentry/sentry-javascript-bundler-plugins#652)) - fix(webpack): Ensure process exits when done ([#653](getsentry/sentry-javascript-bundler-plugins#653)) - fix: Use correct replacement matcher for `bundleSizeOptimizations.excludeTracing` ([#644](getsentry/sentry-javascript-bundler-plugins#644)) Work in this release contributed by [@jdelStrother](https://github.com/jdelStrother). Thank you for your contribution!

fix: Wrap injected code in self-invoking function to contain scope

1e3e973

lforst previously approved these changes Jan 7, 2025

View reviewed changes

Fix

6eea7da

timfish commented Jan 7, 2025

View reviewed changes

Lint and update snapshots

28fe7cb

timfish requested a review from lforst January 7, 2025 13:18

timfish changed the title ~~fix: Wrap injected code in self-invoking function to contain scope~~ fix: Wrap injected code in block-statement to contain scope Jan 9, 2025

timfish mentioned this pull request Jan 9, 2025

Release a new major version #651

Closed

lforst approved these changes Jan 15, 2025

View reviewed changes

lforst changed the title ~~fix: Wrap injected code in block-statement to contain scope~~ fix!: Wrap injected code in block-statement to contain scope Jan 15, 2025

lforst merged commit b734d45 into getsentry:main Jan 15, 2025
18 checks passed

Lms24 mentioned this pull request Jan 24, 2025

feat(webpack): Gate forced process exit behind experimental flag #663

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix!: Wrap injected code in block-statement to contain scope #646

fix!: Wrap injected code in block-statement to contain scope #646

timfish commented Jan 7, 2025 •

edited

Loading

lforst left a comment

timfish commented Jan 7, 2025 •

edited

Loading

timfish Jan 7, 2025 •

edited

Loading

lforst Jan 7, 2025

timfish Jan 7, 2025 •

edited

Loading

fix!: Wrap injected code in block-statement to contain scope #646

fix!: Wrap injected code in block-statement to contain scope #646

Conversation

timfish commented Jan 7, 2025 • edited Loading

lforst left a comment

Choose a reason for hiding this comment

timfish commented Jan 7, 2025 • edited Loading

timfish Jan 7, 2025 • edited Loading

Choose a reason for hiding this comment

lforst Jan 7, 2025

Choose a reason for hiding this comment

timfish Jan 7, 2025 • edited Loading

Choose a reason for hiding this comment

timfish commented Jan 7, 2025 •

edited

Loading

timfish commented Jan 7, 2025 •

edited

Loading

timfish Jan 7, 2025 •

edited

Loading

timfish Jan 7, 2025 •

edited

Loading