Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(replay): network breadcrumbs with tracing disabled were missing start timestamp #4091

Merged
merged 9 commits into from
Jun 25, 2024

Conversation

krystofwoldrich
Copy link
Member

@krystofwoldrich krystofwoldrich commented Jun 20, 2024

📜 Description

Session replay should be independent of the tracing (performance).

💚 How did you test it?

rn sample app

📝 Checklist

You have to check all boxes before merging:

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

@krystofwoldrich krystofwoldrich marked this pull request as draft June 20, 2024 08:15
Copy link

🚨 Detected changes in high risk code 🚨

High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:

  • Sources/Sentry/SentryNetworkTracker.m

Copy link

codecov bot commented Jun 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.333%. Comparing base (6956d43) to head (6a8a314).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              main     #4091   +/-   ##
=========================================
  Coverage   91.332%   91.333%           
=========================================
  Files          610       610           
  Lines        48390     48415   +25     
  Branches     17299     17331   +32     
=========================================
+ Hits         44196     44219   +23     
- Misses        4101      4103    +2     
  Partials        93        93           
Files Coverage Δ
Sources/Sentry/SentryNetworkTracker.m 96.815% <100.000%> (+0.010%) ⬆️
...erformance/Network/SentryNetworkTrackerTests.swift 98.587% <100.000%> (+0.339%) ⬆️

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6956d43...6a8a314. Read the comment docs.

@krystofwoldrich krystofwoldrich marked this pull request as ready for review June 20, 2024 08:51
Copy link

🚨 Detected changes in high risk code 🚨

High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:

  • Sources/Sentry/SentryNetworkTracker.m

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit confused about the test.

Copy link

github-actions bot commented Jun 20, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1212.04 ms 1230.00 ms 17.96 ms
Size 21.58 KiB 671.90 KiB 650.32 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
5e579af 1239.16 ms 1248.49 ms 9.33 ms
06bac56 1205.76 ms 1247.83 ms 42.07 ms
20a828b 1211.33 ms 1228.00 ms 16.67 ms
bbcbaff 1216.82 ms 1242.34 ms 25.52 ms
e072ad1 1241.17 ms 1256.65 ms 15.48 ms
253bb71 1221.62 ms 1250.82 ms 29.20 ms
dc0fe58 1198.56 ms 1220.98 ms 22.42 ms
7bb0873 1208.88 ms 1233.38 ms 24.50 ms
5f8ee7a 1249.48 ms 1252.20 ms 2.72 ms
e89dc54 1220.57 ms 1233.45 ms 12.88 ms

App size

Revision Plain With Sentry Diff
5e579af 21.58 KiB 656.60 KiB 635.01 KiB
06bac56 22.84 KiB 403.23 KiB 380.38 KiB
20a828b 21.58 KiB 670.99 KiB 649.41 KiB
bbcbaff 22.85 KiB 414.09 KiB 391.24 KiB
e072ad1 21.58 KiB 625.83 KiB 604.24 KiB
253bb71 20.76 KiB 393.37 KiB 372.60 KiB
dc0fe58 20.76 KiB 436.50 KiB 415.74 KiB
7bb0873 22.85 KiB 407.09 KiB 384.24 KiB
5f8ee7a 22.85 KiB 411.93 KiB 389.08 KiB
e89dc54 22.85 KiB 412.60 KiB 389.75 KiB

Previous results on branch: kw/replay-network-without-tracing

Startup times

Revision Plain With Sentry Diff
4f065e3 1210.53 ms 1226.87 ms 16.34 ms
aff049f 1204.34 ms 1219.45 ms 15.11 ms
81c776a 1212.82 ms 1227.71 ms 14.89 ms

App size

Revision Plain With Sentry Diff
4f065e3 21.58 KiB 670.47 KiB 648.89 KiB
aff049f 21.58 KiB 675.75 KiB 654.17 KiB
81c776a 21.58 KiB 676.15 KiB 654.57 KiB

Copy link

🚨 Detected changes in high risk code 🚨

High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:

  • Sources/Sentry/SentryNetworkTracker.m

Copy link
Contributor

@brustolin brustolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense. Just one improvement to do.

Copy link

🚨 Detected changes in high risk code 🚨

High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:

  • Sources/Sentry/SentryNetworkTracker.m

Copy link

github-actions bot commented Jun 25, 2024

🚨 Detected changes in high risk code 🚨

High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:

  • Sources/Sentry/SentryNetworkTracker.m

Copy link

github-actions bot commented Jun 25, 2024

🚨 Detected changes in high risk code 🚨

High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:

  • Sources/Sentry/SentryNetworkTracker.m

@brustolin brustolin merged commit 2e3ef92 into main Jun 25, 2024
66 checks passed
@brustolin brustolin deleted the kw/replay-network-without-tracing branch June 25, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants