Merge 79fcb22 into 8001609

getsentry · Jun 20, 2024 · 4f065e3 · 4f065e3
2 parents 8001609 + 79fcb22
commit 4f065e3
Show file tree

Hide file tree

Showing 3 changed files with 115 additions and 79 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -9,6 +9,7 @@
 ### Fixes
 
 - `storeEnvelope` ends session for unhandled errors (#4073)
+- Sentry Replay Network details should be available without Tracing (#4091)
 
 ## 8.29.1
 

diff --git a/Sources/Sentry/SentryNetworkTracker.m b/Sources/Sentry/SentryNetworkTracker.m
@@ -163,6 +163,10 @@ - (void)urlSessionTaskResume:(NSURLSessionTask *)sessionTask
         return;
     }
 
+    // Register request start date in the sessionTask to use for breadcrumb
+    objc_setAssociatedObject(sessionTask, &SENTRY_NETWORK_REQUEST_START_DATE, [NSDate date],
+        OBJC_ASSOCIATION_RETAIN_NONATOMIC);
+
     @synchronized(self) {
         if (!self.isNetworkTrackingEnabled) {
             [self addTraceWithoutTransactionToTask:sessionTask];
@@ -220,10 +224,6 @@ - (void)urlSessionTaskResume:(NSURLSessionTask *)sessionTask
             @"SentryNetworkTracker automatically started HTTP span for sessionTask: %@",
             netSpan.description);
 
-        // Register request start date in the sessionTask to use for breadcrumb
-        objc_setAssociatedObject(sessionTask, &SENTRY_NETWORK_REQUEST_START_DATE, [NSDate date],
-            OBJC_ASSOCIATION_RETAIN_NONATOMIC);
-
         objc_setAssociatedObject(sessionTask, &SENTRY_NETWORK_REQUEST_TRACKER_SPAN, netSpan,
             OBJC_ASSOCIATION_RETAIN_NONATOMIC);
     }