Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: Remove not existent SentryContext #2320

Merged
merged 1 commit into from
Oct 24, 2022

Conversation

philipphofmann
Copy link
Member

The SentryEvent had a @Class definition for SentryContext, which doesn't exist.

#skip-changelog

The SentryEvent had a @Class definition for SentryContext, which
doesn't exist.
@github-actions
Copy link

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1240.31 ms 1249.08 ms 8.77 ms
Size 20.50 KiB 338.99 KiB 318.49 KiB

Baseline results on branch: master

Startup times

Revision Plain With Sentry Diff
e43ce74 1235.77 ms 1252.06 ms 16.29 ms
202334c 1265.41 ms 1277.34 ms 11.93 ms
be47c6c 1228.57 ms 1247.10 ms 18.53 ms
7977992 1219.80 ms 1241.92 ms 22.12 ms
4a188b8 1245.57 ms 1266.04 ms 20.47 ms
8607e67 1240.00 ms 1270.55 ms 30.55 ms
0fdf0b2 1194.37 ms 1227.90 ms 33.53 ms
4a0c282 1228.60 ms 1250.74 ms 22.14 ms
be47c6c 1235.71 ms 1268.02 ms 32.31 ms
db5f62a 1234.47 ms 1257.80 ms 23.33 ms

App size

Revision Plain With Sentry Diff
e43ce74 20.51 KiB 335.49 KiB 314.99 KiB
202334c 20.51 KiB 331.79 KiB 311.28 KiB
be47c6c 20.50 KiB 333.55 KiB 313.04 KiB
7977992 20.50 KiB 333.58 KiB 313.07 KiB
4a188b8 20.50 KiB 337.70 KiB 317.20 KiB
8607e67 20.50 KiB 338.99 KiB 318.49 KiB
0fdf0b2 20.51 KiB 332.90 KiB 312.39 KiB
4a0c282 20.51 KiB 333.10 KiB 312.60 KiB
be47c6c 20.50 KiB 333.54 KiB 313.04 KiB
db5f62a 20.51 KiB 333.16 KiB 312.65 KiB

@philipphofmann philipphofmann merged commit 52d5622 into master Oct 24, 2022
@philipphofmann philipphofmann deleted the ref/remove-sentry-context branch October 24, 2022 13:18
kevinrenskers added a commit that referenced this pull request Oct 24, 2022
* master:
  fix: Fix moving app state to previous app state (#2321)
  ci: Remove macos-10.15 usage (#2312)
  ref: Remove not existent SentryContext (#2320)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants