ci: Remove macos-10.15 usage #2312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 94b4f2b | 1243.31 ms | 1262.06 ms | 18.75 ms |
| 791123d | 1217.52 ms | 1253.08 ms | 35.56 ms |
| be47c6c | 1230.39 ms | 1261.71 ms | 31.33 ms |
| 075911d | 1256.73 ms | 1271.22 ms | 14.49 ms |
| 0fdf0b2 | 1194.37 ms | 1227.90 ms | 33.53 ms |
| 9231f60 | 1256.78 ms | 1267.74 ms | 10.96 ms |
| 7977992 | 1219.80 ms | 1241.92 ms | 22.12 ms |
| fbeb49a | 1218.13 ms | 1243.70 ms | 25.57 ms |
| c929040 | 1254.84 ms | 1278.42 ms | 23.58 ms |
| fa64784 | 1203.98 ms | 1226.16 ms | 22.18 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 94b4f2b | 20.50 KiB | 337.70 KiB | 317.20 KiB |
| 791123d | 20.51 KiB | 331.81 KiB | 311.30 KiB |
| be47c6c | 20.50 KiB | 333.54 KiB | 313.04 KiB |
| 075911d | 20.51 KiB | 332.90 KiB | 312.39 KiB |
| 0fdf0b2 | 20.51 KiB | 332.90 KiB | 312.39 KiB |
| 9231f60 | 20.51 KiB | 333.58 KiB | 313.07 KiB |
| 7977992 | 20.50 KiB | 333.58 KiB | 313.07 KiB |
| fbeb49a | 20.51 KiB | 333.51 KiB | 313.00 KiB |
| c929040 | 20.51 KiB | 333.10 KiB | 312.59 KiB |
| fa64784 | 20.50 KiB | 335.95 KiB | 315.45 KiB |
philipphofmann
commented
Oct 21, 2022
| @@ -67,8 +67,8 @@ class LaunchUITests: XCTestCase { | |||
| let app = XCUIApplication() | |||
| app.navigationBars["iOS_Swift.SecondarySplitView"].buttons["Root ViewController"].waitForExistence("SplitView not loaded.") | |||
|
|
|||
| // This validation is currently not working on iOS 10. | |||
| if #available(iOS 11.0, *) { | |||
| // This validation is currently not working on iOS 12 and iOS 10. | |||
There was a problem hiding this comment.
I created an issue for enabling the test again #2313
brustolin
approved these changes
Oct 24, 2022
|
I'm also a bit worried, but we can try, and if it takes too long, we can reevaluate. |
|
We could consider moving more time-intensive tests for older versions to a nightly build and just fix any issues they turn up async. |
Yes, I would go with that option, if the tests get slow. I would keep them running for every PR for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GH actions will remove the macOS-10.15 image, which contains an iOS 12 simulator on 12/1/22; see actions/runner-images#5583. Neither the macOS-11 nor the macOS-12 image contains an iOS 12 simulator. GH concluded to not add more pre-installed simulators. SauceLabs doesn't support running unit tests and adding another cloud solution as Firebase TestLab would increase the complexity of CI. Not running the unit tests on iOS 12 opens a risk of introducing bugs, which has already happened in the past, especially with swizzling. Therefore, we give manually installing the iOS 12 simulator a try.
Fixes GH-2218