Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(general): Add schema for success metrics #593

Merged
merged 3 commits into from
May 29, 2020
Merged

feat(general): Add schema for success metrics #593

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ad43625
ref: Add schema for success metrics
untitaker May 28, 2020
8ba45b7
rename as suggested
untitaker May 28, 2020
047a1af
rename again as per slack convo
untitaker May 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions relay-general/src/protocol/metrics.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,24 @@ pub struct Metrics {
/// This metric is measured in Sentry and reported in the javascript processing task.
#[metastructure(field = "ms.processing.sourcemaps")]
pub ms_processing_sourcemaps: Annotated<u64>,

/// Whether there has been a processing error that likely impacts the usefulness of an event.
///
/// Example: malformed/unparseable debug information files.
///
/// This metric is measured in Sentry and should be reported in all processing tasks.
#[metastructure(field = "flag.error.processing")]
pub flag_error_processing: Annotated<bool>,

/// Whether there has been a processing error that almost certainly renders the event
/// unusuable.
///
/// Example: Minidump could not be parsed, but we do not drop the event as it may still contain
/// context data and attachments, and we already billed the user anyway.
///
/// This metric is measured in Sentry and should be reported in all processing tasks.
#[metastructure(field = "flag.fatal.processing")]
pub flag_fatal_processing: Annotated<bool>,
}

// Do not process Metrics
Expand Down