feat(general): Add schema for success metrics #593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitsuhiko
approved these changes
May 28, 2020
jan-auer
reviewed
May 28, 2020
| /// Example: malformed/unparseable debug information files. | ||
| /// | ||
| /// This metric is measured in Sentry and should be reported in all processing tasks. | ||
| #[metastructure(field = "error.processing")] |
There was a problem hiding this comment.
To go in line with the others, should we rather call this num.processing.errored and num.processing.failed?
There was a problem hiding this comment.
it's a boolean though. maybe flag, bool or even is.processing.failed?
There was a problem hiding this comment.
Oh, right. All of these sound good 👍
Do we want to count errors maybe? I don't see much value in it, so the flag should be enough.
There was a problem hiding this comment.
I have an implementation of this linked in the PR description and I'd say it's too hard and may be misleading as we don't really know how much soft errors are swallowed by fatal errors.
jan-auer
approved these changes
May 28, 2020
jan-auer
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This serves only documentation purposes. Adds metrics for errors and failures in the processing pipeline.
Used in getsentry/sentry#19068