Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(metrics): Extract more metrics from spans #2080

Merged
merged 6 commits into from
May 2, 2023

Conversation

iker-barriocanal
Copy link
Contributor

Follow-up to #2069.

Adds the remaining metrics with their tags.

#skip-changelog

Copy link
Member

@jjbayer jjbayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

relay-server/src/metrics_extraction/transactions/mod.rs Outdated Show resolved Hide resolved
relay-server/src/metrics_extraction/transactions/mod.rs Outdated Show resolved Hide resolved
@TBS1996
Copy link
Contributor

TBS1996 commented May 2, 2023

would it make sense to also make a enum SpanMetric in the way we do with TrasnactionMetric and SessionMetric?

@iker-barriocanal iker-barriocanal merged commit e8818fb into master May 2, 2023
@iker-barriocanal iker-barriocanal deleted the iker/feat/span-metrics branch May 2, 2023 11:41
@iker-barriocanal
Copy link
Contributor Author

@TBS1996 Yes, it does. That is a follow-up step after we're no longer a blocker.

jan-auer added a commit that referenced this pull request May 9, 2023
* master: (178 commits)
  ref(crons): Allow `_` in monitor slugs (#2100)
  fix(span-metrics): Scrub subdomains in metric tags (#2103)
  feat(normalization): Scrub span description URLs (#2095)
  feat(dynamic-sampling): Add possibility to run dynamic sampling from `sentry-relay` (#2091)
  ref(dynamic-config): Remove transaction metrics allowlist from Sentry (#2092)
  feat(protocol): Support old effective-directory format (#2048)
  ref(spans): Add more tags to span metrics (#2090)
  fix(server): Support HTTP half-close connections (#2089)
  ref(spans): Use transactions namespace with `span` prefix (#2087)
  ref(spans): Update span metrics feature flag name (#2086)
  feat(metrics): Extract more metrics from spans (#2080)
  build: Bump tempfile to remove flagged dependency (#2085)
  feat(filter): Add document_uri csp filter (#2059)
  build: Use jemalloc on Linux (#2084)
  ci(gha): add debugging for "Couldn'\''t write tracker file" issue (#2081)
  feat(crons): Pass-through minimal `sdk` field (#2073)
  fix(quota): Parse large limits (#2079)
  instr(server): More details on unexpected envelope drop (#2077)
  fix(ci): Skip flaky integration test (#2076)
  feat(dynamic-sampling): Add support for `trace.replay_id` in matching rules (#2070)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants