Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ci): Skip flaky integration test #2076

Merged
merged 2 commits into from
Apr 27, 2023
Merged

fix(ci): Skip flaky integration test #2076

merged 2 commits into from
Apr 27, 2023

Conversation

jjbayer
Copy link
Member

@jjbayer jjbayer commented Apr 27, 2023 •
edited
Loading

#skip-changelog

@jjbayer jjbayer marked this pull request as ready for review April 27, 2023 13:32
@jjbayer jjbayer requested a review from a team April 27, 2023 13:32
iker-barriocanal
iker-barriocanal approved these changes Apr 27, 2023
View reviewed changes
Copy link
Contributor

@iker-barriocanal iker-barriocanal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we create a ticket to prioritize and keep track of fixing this, if there isn't one already?

@jjbayer jjbayer mentioned this pull request Apr 27, 2023
Closed
@jjbayer
Copy link
Member Author

jjbayer commented Apr 27, 2023

Could we create a ticket to prioritize and keep track of fixing this, if there isn't one already?

Good point. #2078

@jjbayer jjbayer merged commit 2e6f857 into master Apr 27, 2023
@jjbayer jjbayer deleted the fix/disable-flaky-test branch April 27, 2023 14:06
jan-auer added a commit that referenced this pull request May 2, 2023
@jan-auer
Merge branch 'master' into build/jemalloc
cb3dfb6 
* master:
  ci(gha): add debugging for "Couldn'\''t write tracker file" issue (#2081)
  feat(crons): Pass-through minimal `sdk` field (#2073)
  fix(quota): Parse large limits (#2079)
  instr(server): More details on unexpected envelope drop (#2077)
  fix(ci): Skip flaky integration test (#2076)
jan-auer added a commit that referenced this pull request May 9, 2023
@jan-auer
Merge branch 'master' into remove-unsupported-macos-15
c974258 
* master: (178 commits)
  ref(crons): Allow `_` in monitor slugs (#2100)
  fix(span-metrics): Scrub subdomains in metric tags (#2103)
  feat(normalization): Scrub span description URLs (#2095)
  feat(dynamic-sampling): Add possibility to run dynamic sampling from `sentry-relay` (#2091)
  ref(dynamic-config): Remove transaction metrics allowlist from Sentry (#2092)
  feat(protocol): Support old effective-directory format (#2048)
  ref(spans): Add more tags to span metrics (#2090)
  fix(server): Support HTTP half-close connections (#2089)
  ref(spans): Use transactions namespace with `span` prefix (#2087)
  ref(spans): Update span metrics feature flag name (#2086)
  feat(metrics): Extract more metrics from spans (#2080)
  build: Bump tempfile to remove flagged dependency (#2085)
  feat(filter): Add document_uri csp filter (#2059)
  build: Use jemalloc on Linux (#2084)
  ci(gha): add debugging for "Couldn'\''t write tracker file" issue (#2081)
  feat(crons): Pass-through minimal `sdk` field (#2073)
  fix(quota): Parse large limits (#2079)
  instr(server): More details on unexpected envelope drop (#2077)
  fix(ci): Skip flaky integration test (#2076)
  feat(dynamic-sampling): Add support for `trace.replay_id` in matching rules (#2070)
  ...
@jjbayer jjbayer mentioned this pull request Jan 11, 2024
Merged
jjbayer added a commit that referenced this pull request Jan 11, 2024
@jjbayer
test(metrics): Restore graceful shutdown test (#2933)
792e0af 
Fixes #2076
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olksdr olksdr olksdr approved these changes

@iker-barriocanal iker-barriocanal iker-barriocanal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jjbayer @olksdr @iker-barriocanal