Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve button link usage #5409

Closed
wants to merge 29 commits into from
Closed

Improve button link usage #5409

wants to merge 29 commits into from

Commits on Feb 25, 2021

  1. Refactor of link component 

    Added auto tabindex for link component

Improved accessibility of link component

Restricted scope of link component

Render ButtonLinks as Buttons
    @rafawendel
    rafawendel committed Feb 25, 2021
    Configuration menu
    Copy the full SHA
    e1512c1 View commit details
    Browse the repository at this point in the history

  2. Replaced uses of anchor to Link component

    @rafawendel
    rafawendel committed Feb 25, 2021
    Configuration menu
    Copy the full SHA
    9a7810a View commit details
    Browse the repository at this point in the history

  3. Removed poor use of ButtonLink

    @rafawendel
    rafawendel committed Feb 25, 2021
    Configuration menu
    Copy the full SHA
    ab7a9d2 View commit details
    Browse the repository at this point in the history

  4. Added custom Button component

    @rafawendel
    rafawendel committed Feb 25, 2021
    Configuration menu
    Copy the full SHA
    533995e View commit details
    Browse the repository at this point in the history

  5. Replaced Link role button instances with Button type plain

    @rafawendel
    rafawendel committed Feb 25, 2021
    Configuration menu
    Copy the full SHA
    83dc7ab View commit details
    Browse the repository at this point in the history

  6. Applied anchor-is-valid to Link component

    @rafawendel
    rafawendel committed Feb 25, 2021
    Configuration menu
    Copy the full SHA
    c18da8f View commit details
    Browse the repository at this point in the history

  7. Improved uses and removed redundancies from buttons

    @rafawendel
    rafawendel committed Feb 25, 2021
    Configuration menu
    Copy the full SHA
    d6ac6f1 View commit details
    Browse the repository at this point in the history

  8. Updated opportunistic uses for Link and Button

    @rafawendel
    rafawendel committed Feb 25, 2021
    Configuration menu
    Copy the full SHA
    3c27c32 View commit details
    Browse the repository at this point in the history

  9. Split PlainButton and ant Button

    @rafawendel
    rafawendel committed Feb 25, 2021
    Configuration menu
    Copy the full SHA
    b3361e5 View commit details
    Browse the repository at this point in the history

  10. Fixed types for CardsList

    @rafawendel
    rafawendel committed Feb 25, 2021
    Configuration menu
    Copy the full SHA
    44c7184 View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2021

  1. Trigger build

    @rafawendel
    rafawendel committed Mar 1, 2021
    Configuration menu
    Copy the full SHA
    8a98959 View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2021

  1. Merge branch 'master' of github.com:getredash/redash into improve-but… 

    …ton-link-usage
    @rafawendel
    rafawendel committed Mar 4, 2021
    Configuration menu
    Copy the full SHA
    85f2831 View commit details
    Browse the repository at this point in the history

  2. Removed buttons inside menuitems

    @rafawendel
    rafawendel committed Mar 4, 2021
    Configuration menu
    Copy the full SHA
    93ff830 View commit details
    Browse the repository at this point in the history

  3. Added link like plain button

    @rafawendel
    rafawendel committed Mar 4, 2021
    Configuration menu
    Copy the full SHA
    90f6c88 View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2021

  1. Changed to imported styles

    @rafawendel
    rafawendel committed Mar 5, 2021
    Configuration menu
    Copy the full SHA
    fdd5bb1 View commit details
    Browse the repository at this point in the history

  2. Reverted improper ul usage

    @rafawendel
    rafawendel committed Mar 5, 2021
    Configuration menu
    Copy the full SHA
    137a9ba View commit details
    Browse the repository at this point in the history

  3. Inverted mistakenly swapped ternary

    @rafawendel
    rafawendel committed Mar 5, 2021
    Configuration menu
    Copy the full SHA
    532cdb2 View commit details
    Browse the repository at this point in the history

  4. Restored mistakenly removed Button

    @rafawendel
    rafawendel committed Mar 5, 2021
    Configuration menu
    Copy the full SHA
    f2dfd06 View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2021

  1. Added link style button to proper elements

    @rafawendel
    rafawendel committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    e710faf View commit details
    Browse the repository at this point in the history

  2. Revert "Removed buttons inside menuitems" 

    This reverts commit 93ff830.
    @rafawendel
    rafawendel committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    3e24e0c View commit details
    Browse the repository at this point in the history

  3. Added styles for plain button inside menu item

    @rafawendel
    rafawendel committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    0caf343 View commit details
    Browse the repository at this point in the history

  4. Added styles for focus in menuitems

    @rafawendel
    rafawendel committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    b281eff View commit details
    Browse the repository at this point in the history

  5. Added style to favorite star

    @rafawendel
    rafawendel committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    c07546e View commit details
    Browse the repository at this point in the history

  6. Removed redundant style

    @rafawendel
    rafawendel committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    907f37c View commit details
    Browse the repository at this point in the history

  7. Improved appearance and accessibility of widgets

    @rafawendel
    rafawendel committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    8afaa37 View commit details
    Browse the repository at this point in the history

  8. Removed accidentally added classes

    @rafawendel
    rafawendel committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    31ee6b0 View commit details
    Browse the repository at this point in the history

  9. Fixed accessibility and behavior of edit in place

    @rafawendel
    rafawendel committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    8c49157 View commit details
    Browse the repository at this point in the history

  10. Fixed unwanted visual changes, added a11y friendly styles, improved m… 

    …inor UI behavior
    @rafawendel
    rafawendel committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    169761c View commit details
    Browse the repository at this point in the history

  11. Replaced imporper uses of <Button type="linK">

    @rafawendel
    rafawendel committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    646ed3e View commit details
    Browse the repository at this point in the history