Improve button link usage #5409
Conversation
Added auto tabindex for link component Improved accessibility of link component Restricted scope of link component Render ButtonLinks as Buttons
rafawendel
force-pushed
the
improve-button-link-usage
branch
from
c1053fb
to
44c7184
Compare
This reverts commit 93ff830.
|
Note: |
| @@ -100,6 +100,10 @@ strong { | |||
| cursor: pointer; | |||
| } | |||
|
|
|||
| .clickable:disabled { | |||
There was a problem hiding this comment.
Not sure there's an action to take, yet, but I have mixed feelings about this. Anything can take the classname clickable, but not anything can be disabled.
There was a problem hiding this comment.
What about .clickable button:disabled?
| @@ -391,6 +391,18 @@ | |||
| left: 0; | |||
There was a problem hiding this comment.
I'm leaving a comment here so we can keep a discussion in the thread.
Is there any chance we can break this PR into even smaller PRs? It looks like there are quite a few styling changes, as well as component updates. I'm having trouble determining how best to QA / ensure there are no regressions.
Do you have another proposal? I don't want to stonewall you or anything, but I don want to make sure I can limit the number of iterations / time spent verifying changes.
There was a problem hiding this comment.
That's complicated. I did think about it, but the thing is that this PR resulted in a lot of visual changes, which I had to solve in order to be mergeable. What is sort of possible but somewhat weird is having the fixes for those in master before we merge it. LMK what is your opinion on that.
An alternative is to review those last commits primarily, since they are where the styling changes are amassed.
There was a problem hiding this comment.
What if we just did one button type at a time?
What type of PR is this? (check all applicable)
Description
This PR is a split on #5365 due to its staleness.
It aims to fix issues on interactivity and improve keyboard accessibility.
All anchors
<a>need to be replaced by proper semantic components other than those inviz-lib.The following behavior for links, buttons, link-like and button-like components is aimed:
<Link>- Renders<a><Button>- Renders Antd<Button><Link.Button>- Renders Antd<Button>, which is rendered as an<a><PlainButton>- Renders styleless<button>