Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deal with broken embedded video links when importing from Tumblr #3218

Merged
merged 2 commits into from
Oct 28, 2023
Merged

Deal with broken embedded video links when importing from Tumblr #3218

merged 2 commits into from
Oct 28, 2023

Conversation

boxydog
Copy link
Contributor

@boxydog boxydog commented Oct 27, 2023 •
edited
Loading

Pull Request Checklist

Resolves: #3177

  • Ensured tests pass and (if applicable) updated functional test output
  • Conformed to code style guidelines by running appropriate linting tools
  • Added tests for changed code
  • Updated documentation for changed code

@boxydog
Copy link
Contributor Author

boxydog commented Oct 27, 2023

This is like #3181, but with an informative message in the resulting text ("This video isn't available anymore."), and unit tests.

@boxydog boxydog mentioned this pull request Oct 27, 2023
Closed
4 tasks
justinmayer
justinmayer approved these changes Oct 28, 2023
View reviewed changes
Copy link
Member

@justinmayer justinmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the comprehensive work on this, @boxydog! 🥇

@justinmayer justinmayer merged commit 9c87d8f into getpelican:master Oct 28, 2023
10 checks passed
@boxydog boxydog deleted the fix_3177 branch May 31, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinmayer justinmayer justinmayer approved these changes

@avaris avaris avaris approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pelican import fails on tumblr blog entry
3 participants
@boxydog @avaris @justinmayer