Fix orphaned embedded video links from Tumblr. Fix #3177 #3181
Conversation
|
It's been two months. What's blocking this merge? Is it documentation? Is there something I can do? |
|
It’s just been a busy period. I appreciate the offer to help out. There is a Pelican sprint planned for this weekend, so this PR will be merged then if not sooner. Feel free to join us this weekend if you’d like to collaborate and work on Pelican together. 🌟 |
| try: | ||
| players = '\n'.join(player.get('embed_code') | ||
| for player in post.get('player')) | ||
| except TypeError: |
There was a problem hiding this comment.
This does work. My question is: is it okay to fail silently, or should there at least be something in the output that says "Video missing" or "Video removed" or something?
There was a problem hiding this comment.
Good point. There should probably be a line here with something like:
logger.warning(f"Video not imported due to broken embedded video links: {some-appropriate-variable}")What do you think, @willthong?
There was a problem hiding this comment.
I was actually thinking something in the generated output.
If I'm importing 100 posts, I'm not going to know which one broke, and I'm not looking too closely at warnings.
I'd be willing to work on this, but only after #3215 is merged (to get the unit testing setup).
There was a problem hiding this comment.
That would indeed be clearer. Thanks for offering to work on this. I just merged 3215. 👍
There was a problem hiding this comment.
Put up a new PR #3218, based on this one.
|
Merged via #3218. Many thanks for your help with this, Will! 💫 |
Where a Tumblr video links to an orphaned video (eg https://www.tumblr.com/boxydog/148936576299/two-opposite-personalities-one-driven-to-big),
pelican-importcrashes as it tries to define aplayersvariable from a "player" record in Tumblr's JSON API output which doesn't exist.Pull Request Checklist
Resolves: #3177