Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Center the icon in the toolbar in full screen dialogs #5890

Merged
merged 1 commit into from
Jan 3, 2024

Conversation

grzesiek2010
Copy link
Member

@grzesiek2010 grzesiek2010 commented Jan 3, 2024

Closes #5889

Why is this the best possible solution? Were any other approaches considered?

There is nothing to discuss here. I've just centered the icon so that it's aligned with the title.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

We just need to test full-screen dialogs that use icons. The three dialogs mentioned in the issue should be enough.

Do we need any specific form for testing your changes? If so, please attach one.

No.

Does this change require updates to documentation? If so, please file an issue here and include the link below.

No.

Before submitting this PR, please make sure you have:

  • added or modified tests for any new or changed behavior
  • run ./gradlew connectedAndroidTest (or ./gradlew testLab) and confirmed all checks still pass
  • added a comment above any new strings describing it for translators
  • verified that any code or assets from external sources are properly credited in comments and/or in the about file.
  • verified that any new UI elements use theme colors. UI Components Style guidelines

@grzesiek2010 grzesiek2010 marked this pull request as ready for review January 3, 2024 16:44
@grzesiek2010 grzesiek2010 requested a review from seadowg January 3, 2024 16:44
@seadowg seadowg merged commit e69ca57 into getodk:master Jan 3, 2024
@srujner
Copy link

srujner commented Jan 4, 2024

Tested with Success!

Verified on device with Android 10,12,13

Verified cases:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The icon in the toolbar in full screen dialogs is not vertically aligned with the title
3 participants