-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed displaying valid and invalid drafts on a map #5786
Conversation
@@ -194,7 +194,7 @@ class FormMapViewModel( | |||
|
|||
private fun getDrawableIdForStatus(status: String, enlarged: Boolean): Int { | |||
return when (status) { | |||
Instance.STATUS_INCOMPLETE -> if (enlarged) R.drawable.ic_room_form_state_incomplete_48dp else R.drawable.ic_room_form_state_incomplete_24dp | |||
Instance.STATUS_INCOMPLETE, Instance.STATUS_VALID, Instance.STATUS_INVALID -> if (enlarged) R.drawable.ic_room_form_state_incomplete_48dp else R.drawable.ic_room_form_state_incomplete_24dp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might want to distinguish somehow valid
and invalid
instances (by displaying different icons/info) but that's something for a separate issue that could be a part of v2023.4 @lognaturel what do you think?
Tested with Success! Verified on device with Android 10 Verified cases:
|
Tested with Success! Verified on device with Android 13 |
Fixed displaying valid and invalid drafts on a map
Fixed displaying valid and invalid drafts on a map
Closes #5783
Why is this the best possible solution? Were any other approaches considered?
I've updated the method responsible for returning map icons based on the status. Both
valid
andinvalid
drafts are displayed in the same way likeincomplete
ones before (with a blue icon).How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
This is a small change so testing the scenario described in the issue should be enough. However, there might be also other similar issues caused by introducing new instance statuses (
valid
andinvalid
) so be careful.Do we need any specific form for testing your changes? If so, please attach one.
No.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.
Before submitting this PR, please make sure you have:
./gradlew checkAll
and confirmed all checks still pass OR confirm CircleCI build passes and run./gradlew connectedDebugAndroidTest
locally.