Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the way valid/invalid drafts are displayed on a map #5787

Closed
grzesiek2010 opened this issue Oct 20, 2023 · 3 comments · Fixed by #6000
Closed

Update the way valid/invalid drafts are displayed on a map #5787

grzesiek2010 opened this issue Oct 20, 2023 · 3 comments · Fixed by #6000
Assignees
Milestone

Comments

@grzesiek2010
Copy link
Member

grzesiek2010 commented Oct 20, 2023

Problem description

As I said in #5786 (comment)
drafts might have valid/invalid status but they are displayed on a map in the same way.

Solution

Display the errors/no errors pill on a bottom sheet so users still have the map's context when assessing what action they need to take.

  • Changing the information hierarchy to match the drafts list
  • Removing the form icon if possible, if not, could we make it black so it's consistent with the others?
  • Edit button moves below the errors label and timestamp
  • Add 'drag handle'

Figma mockup

Edit Nov 23:
One thing I didn't consider was displaying geometry, now that we plan to move the edit button below the error label and timestamp. Given that we are implementing the 'drag handle' at the top of the sheet with the MBtiles work, I would like to use that same functionality here and display the geometry so it's visible, it doesn't fall beneath the fold, and it can expand if needed.

@seadowg
Copy link
Member

seadowg commented Nov 1, 2023

@alyblenkin would be good to get your take on this!

@alyblenkin
Copy link
Collaborator

@seadowg @grzesiek2010 - I think we should keep the design pretty close to how we display errors/no errors in the drafts list. Adding icons to the map might make it more confusing. Figma mockup.

@seadowg
Copy link
Member

seadowg commented Nov 3, 2023

This looks good to me! Could you update the issue description with that and any details you think are important?

@seadowg seadowg added this to the v2024.1 milestone Nov 6, 2023
@seadowg seadowg moved this from not ready to ready in ODK Collect Feb 15, 2024
@grzesiek2010 grzesiek2010 self-assigned this Mar 1, 2024
@grzesiek2010 grzesiek2010 moved this from ready to in progress in ODK Collect Mar 1, 2024
@github-project-automation github-project-automation bot moved this from in progress to done in ODK Collect Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: done
Development

Successfully merging a pull request may close this issue.

3 participants