Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Appearance settings tests" #2477

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

shashwatahalder01
Copy link
Contributor

@shashwatahalder01 shashwatahalder01 commented Dec 11, 2024

Reverts #2458

Summary by CodeRabbit

  • New Features

    • Introduced a new environment variable MAPBOX for enhanced testing configuration.
    • Added new customer features and modified vendor capabilities in the feature map.
  • Bug Fixes

    • Corrected spelling of LICENSE_KEY in configuration files.
    • Enhanced error handling in tests for better state management.
  • Documentation

    • Updated README for improved formatting and clarity.
  • Refactor

    • Simplified test setup and configuration management.
    • Removed redundant methods and optimized selector definitions.
  • Chores

    • Cleaned up unused environment variables and restructured widget definitions.

Copy link
Contributor

coderabbitai bot commented Dec 11, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request introduces several changes across multiple files, primarily focusing on enhancing the configuration and functionality of testing environments. Key modifications include the addition of a new environment variable MAPBOX for E2E API tests, updates to various configuration files, and adjustments to test cases for improved reliability and clarity. Notably, several methods and classes have been renamed or removed, and new features have been added to the feature-map.yml file. Overall, the changes aim to streamline the testing process and improve the management of store appearance and vendor functionalities.

Changes

File Change Summary
.github/workflows/e2e_api_tests.yml Added environment variable MAPBOX: ${{secrets.MAPBOX}}.
tests/pw/.env.example Updated LICENSE_KEY from license_key to licence_key.
tests/pw/README.MD Updated LICENSE_KEY from license_key to licence_key; formatting adjustments made.
tests/pw/e2e.config.ts Updated timeout settings: timeout from 45s to 40s, expect.timeout from 15s to 10s.
tests/pw/feature-map/feature-map.yml Significant updates including feature additions, removals, and renaming of "Feature Lock" to "Feature lock".
tests/pw/fixtures/page.ts Updated import and type declaration for storeAppearance from StoreAppearancePage to StoreAppearance.
tests/pw/pages/basePage.ts Removed methods toExists and notToExists.
tests/pw/pages/privacyPolicyPage.ts Modified contactVendor method by removing an argument from gotoUntilNetworkidle.
tests/pw/pages/selectors.ts Updated various UI element selectors for clarity and consistency.
tests/pw/pages/storeAppearance.ts Added new StoreAppearance class with methods to manage store visibility.
tests/pw/pages/storeAppearancePage.ts Removed StoreAppearancePage class.
tests/pw/tests/e2e/_auth.setup.ts Removed vendor-related setup operations and associated logic.
tests/pw/tests/e2e/_env.setup.ts Minor formatting change in setUserMeta method call.
tests/pw/tests/e2e/catalogmode.spec.ts Enhanced error handling by capturing previous settings before updates.
tests/pw/tests/e2e/commission.spec.ts Updated subscriptionProductId declaration from initialized to uninitialized.
tests/pw/tests/e2e/euCompliance.spec.ts Improved vendor information visibility handling by capturing previous settings.
tests/pw/tests/e2e/liveSearch.spec.ts Updated parameters for dbUtils.updateOptionValue in test.beforeAll.
tests/pw/tests/e2e/privacyPolicy.spec.ts Updated commented-out code and re-enabled a previously skipped test case.
tests/pw/tests/e2e/storeAppearance.spec.ts Renamed StoreAppearancePage to StoreAppearance, shifted focus to customer context.
tests/pw/tests/e2e/vendor.spec.ts Enhanced management of database options by capturing previous settings.
tests/pw/tests/e2e/vendorProductSubscription.spec.ts Updated subscriptionId declaration from initialized to uninitialized.
tests/pw/types/environment.d.ts Removed RECAPTCHA_SITE_KEY and RECAPTCHA_SECRET_KEY properties.
tests/pw/utils/dbData.ts Removed RECAPTCHA_SITE_KEY and RECAPTCHA_SECRET_KEY; added widgets object.
tests/pw/utils/payloads.ts Added VENDOR3 environment variable; updated payloads structure for store creation.
tests/pw/utils/testData.ts Removed storeBanner property from data object.

Possibly related PRs

"In the fields where rabbits play,
New tests and features come our way.
With MAPBOX added, we hop with glee,
As store appearances shine brightly, you see!
From license_key to licence_key,
We leap through changes, oh so sleek! 🐇✨"


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between dfa0ee6 and 89ac515.

📒 Files selected for processing (25)
  • .github/workflows/e2e_api_tests.yml (0 hunks)
  • tests/pw/.env.example (1 hunks)
  • tests/pw/README.MD (2 hunks)
  • tests/pw/e2e.config.ts (1 hunks)
  • tests/pw/feature-map/feature-map.yml (2 hunks)
  • tests/pw/fixtures/page.ts (3 hunks)
  • tests/pw/pages/basePage.ts (0 hunks)
  • tests/pw/pages/privacyPolicyPage.ts (1 hunks)
  • tests/pw/pages/selectors.ts (3 hunks)
  • tests/pw/pages/storeAppearance.ts (1 hunks)
  • tests/pw/pages/storeAppearancePage.ts (0 hunks)
  • tests/pw/tests/e2e/_auth.setup.ts (0 hunks)
  • tests/pw/tests/e2e/_env.setup.ts (1 hunks)
  • tests/pw/tests/e2e/catalogmode.spec.ts (1 hunks)
  • tests/pw/tests/e2e/commission.spec.ts (1 hunks)
  • tests/pw/tests/e2e/euCompliance.spec.ts (1 hunks)
  • tests/pw/tests/e2e/liveSearch.spec.ts (1 hunks)
  • tests/pw/tests/e2e/privacyPolicy.spec.ts (2 hunks)
  • tests/pw/tests/e2e/storeAppearance.spec.ts (1 hunks)
  • tests/pw/tests/e2e/vendor.spec.ts (1 hunks)
  • tests/pw/tests/e2e/vendorProductSubscription.spec.ts (1 hunks)
  • tests/pw/types/environment.d.ts (0 hunks)
  • tests/pw/utils/dbData.ts (5 hunks)
  • tests/pw/utils/payloads.ts (20 hunks)
  • tests/pw/utils/testData.ts (0 hunks)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Experiment)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@shashwatahalder01 shashwatahalder01 merged commit da627b7 into develop Dec 11, 2024
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant