#9683: add Details Panel for MS dashboard #9689

mahmoudadel54 · 2023-11-10T13:43:34Z

Description

It is a new feature added to MS for dashboard. I added Details panel widget to dashboard.

It reflects on Resource grids, dashboard views [View, Edit modes].
The tool have the same options (eg. show as modal, show at startup etc.)
The tool is defined in the same way of the corresponding one for maps.
Edit the layout to put add widget & show/hide connection buttons to the sidebar menu

Please check if the PR fulfills these requirements

The commit message follows our guidelines: https://github.com/geosolutions-it/MapStore2/blob/master/CONTRIBUTING.md
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x", remove the others)

Issue

#9683

What is the current behavior?
#9683

What is the new behavior?
Details panel widget is added for dashboard. User can add/edit dashboard details and set some details for the dashboard and set some options like opening this details on startup, show details on modal/right panel via resource grids and from dashboard view page in view/edit modes.

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

Yes, and I documented them in migration notes
No

- The tool have the same options (eg. show as modal, show at startup etc.) - The tool is defined in the same way of the corresponding one for maps. - Edit the layout to put add widget & show/hide connection buttons to the sidebar menu

Update DashboardEditor.jsx

MV88

there is clearly something wrong here when you create a new dashboard

while it works fine when you load a dashboard

the style of plus button should be blank bg (similar to others) from the start and maybe should be the second one, after login and when pressed it should become like it is now. because primary background means something active
also we should make become a only open button or become unclickable (disabled but visible)
i cannot drag and drop or resize widgets on the right if I load this dashboard: http://localhost:8081/?debug=true#/dashboard/21694

it works until a certain point notice the cursor, maybe that is the space of details panel which covers click on the area

anyway here the placeable area (red background area) looks properly calculated

web/client/actions/__tests__/details-test.js

web/client/components/layout/BorderLayout.jsx

web/client/components/details/DetailsPanel.jsx

web/client/components/misc/panels/DockPanel.jsx

web/client/themes/default/less/panels.less

web/client/plugins/SidebarMenu.jsx

web/client/epics/tutorial.js

web/client/plugins/DashboardEditor.jsx

web/client/plugins/Details.jsx

* description: - remove all dashboard selectors and pieces of code in generic components like sidebar plugin component that relevant to dashboard. - add missing test for detailsLoaded action - create new selectors, details uri selector and details settings se;ector that are used in many places in code - move AddWidgetDashboard, MapConnedctionDashboard plugins to direct plugins folder - Put global spinner in details plugin and remove it from sidebar plugin - edit in handleSave enhancer file to make update attributes of details just implemented for Map and Dashboard - Add custom style in details.less as the lib of react-dock doesn't allow to override left css property - remove unused added style from panels.less

…ore2 into feature_9683

MV88

looks better i have only noticed a few minor things:

the language selector goes behind body panel, but with a z-index it gets fixed, please test
the Save button has no tooltip
loading property is no longer needed in the DashboardEditor plugin

web/client/components/layout/BorderLayout.jsx

mahmoudadel54 · 2023-11-20T06:43:11Z

looks better i have only noticed a few minor things:

the language selector goes behind body panel, but with a z-index it gets fixed, please test

the Save button has no tooltip

loading property is no longer needed in the DashboardEditor plugin

For z-index point, I see that z-index of #mapstore-sidebar-menu-container = 1030
I have tried to put a z-index to #mapstore-navbar-container with 1031 and it works well so I can specify this style in dashblaod.less to be just for dashboard page only instead of generalize it.
https://github.com/geosolutions-it/MapStore2/blob/1e51fd9fa86b6aca7cbb88bcb143cd7bed6d6677/web/client/themes/default/less/dashboard.less#L29C1-L33C1

What do you think ? @MV88

Description: - Reolve unused loading property from DashoardEditor file - Add tooltip for save dashboard - Remove custom style in BorderLayout and leave it with generic style

MV88 · 2023-11-20T08:58:21Z

#mapstore-navbar-container

hi if the fix you found is increasing #mapstore-navbar-container z-index i would not put it inside dashboard.less. but instead in navbar.less and also maybe you can remove the z-index definition of that inside dashboard.less

Description: - edit navbar.less files to fix going language selector behind body panel - remove unused z-index in dashboard.less

MV88 · 2023-11-21T09:21:58Z

@ElenaGallo please test in DEV

ElenaGallo · 2023-11-22T14:40:57Z

@mahmoudadel54 @tdipisa There are no Export, Import and Delete buttons in the new sidebar.

QA

DEV

MV88 · 2023-11-24T16:34:50Z

this has to be backported in c040-2023.02.xx

…s-it#9689) * geosolutions-it#9683: add Details Panel for MS dashboard - The tool have the same options (eg. show as modal, show at startup etc.) - The tool is defined in the same way of the corresponding one for maps. - Edit the layout to put add widget & show/hide connection buttons to the sidebar menu * geosolutions-it#9683: resolve the FE test Update DashboardEditor.jsx * geosolutions-it#9683: resolve review comments * description: - remove all dashboard selectors and pieces of code in generic components like sidebar plugin component that relevant to dashboard. - add missing test for detailsLoaded action - create new selectors, details uri selector and details settings se;ector that are used in many places in code - move AddWidgetDashboard, MapConnedctionDashboard plugins to direct plugins folder - Put global spinner in details plugin and remove it from sidebar plugin - edit in handleSave enhancer file to make update attributes of details just implemented for Map and Dashboard - Add custom style in details.less as the lib of react-dock doesn't allow to override left css property - remove unused added style from panels.less * geosolutions-it#9683: remove unused comments in dashboard-test file * geosolutions-it#9683: edit in details epics and selectors to fix FE test * geosolutions-it#9683: Resolve review comments Description: - Reolve unused loading property from DashoardEditor file - Add tooltip for save dashboard - Remove custom style in BorderLayout and leave it with generic style * geosolutions-it#9683: resolve review comments Description: - edit navbar.less files to fix going language selector behind body panel - remove unused z-index in dashboard.less # Conflicts: # web/client/epics/__tests__/config-test.js # web/client/epics/config.js

mahmoudadel54 · 2023-11-27T08:53:03Z

this has to be backported in c040-2023.02.xx

Backport is done --- > #9750

* Fix #9624 Point cloud shading options (#9666) * Fix #9666 Include pointCloudShading option to saved layer config (#9670) * #9606 Error with circle annotations + radius selection (#9607) (#9727) Co-authored-by: Diego Vargas <[email protected]> * Fix #9295 added better handling of format in csw service (#9712) (#9732) * #9702: Fix - Background selector in contexts won't retain thumbnail in view mode (#9720) (#9744) * #9567: handle functionality of zoom to record in table widgets (#9608) * #9567: handle functionality of zoom to record in table widgets * Fix: Correct failing test cases for zoom records issue in table widgets (#9567) This commit addresses the failing test cases related to the issue of zoom records in table widgets. * #9567: implement the new approach in zoom to records in table widgets + writing unit tests * #9567: handle adding flag into config file to show/hide zoom icon for tblWidget * #9567: reset flag enableZoomInTblWidget to be true for dashboard and map viewer * #9567: resolve comments' review: - put flag of zoomInTblWidget as a default prop - add translations - edit zoomToExtent enhancer to use internal zoom - remove selector "getFlagOfShowingTblWidgetZoom " and use plugin prop instead * #9683: add Details Panel for MS dashboard (#9689) * #9683: add Details Panel for MS dashboard - The tool have the same options (eg. show as modal, show at startup etc.) - The tool is defined in the same way of the corresponding one for maps. - Edit the layout to put add widget & show/hide connection buttons to the sidebar menu * #9683: resolve the FE test Update DashboardEditor.jsx * #9683: resolve review comments * description: - remove all dashboard selectors and pieces of code in generic components like sidebar plugin component that relevant to dashboard. - add missing test for detailsLoaded action - create new selectors, details uri selector and details settings se;ector that are used in many places in code - move AddWidgetDashboard, MapConnedctionDashboard plugins to direct plugins folder - Put global spinner in details plugin and remove it from sidebar plugin - edit in handleSave enhancer file to make update attributes of details just implemented for Map and Dashboard - Add custom style in details.less as the lib of react-dock doesn't allow to override left css property - remove unused added style from panels.less * #9683: remove unused comments in dashboard-test file * #9683: edit in details epics and selectors to fix FE test * #9683: Resolve review comments Description: - Reolve unused loading property from DashoardEditor file - Add tooltip for save dashboard - Remove custom style in BorderLayout and leave it with generic style * #9683: resolve review comments Description: - edit navbar.less files to fix going language selector behind body panel - remove unused z-index in dashboard.less # Conflicts: # web/client/epics/__tests__/config-test.js # web/client/epics/config.js * #9683: resolve test comment (#9730) - Adding export, import, delete dashboard - Reorder shown plugins in sidebar for dashboard * #9683: add Details Panel for MS dashboard [Editing the detail panel tooltip and title] (#9740) * #9683: resolve test comment Description: - edit the detail panel tooltip and shown title and make it generic one - Add translations for the new tooltip * Update web/client/translations/data.it-IT.json --------- Co-authored-by: Matteo V <[email protected]> * #9728 fix misalignement issue (#9731) (#9742) * Fix #9729 fixed formats in catalog used in dashboard (#9733) (#9747) --------- Co-authored-by: stefano bovio <[email protected]> Co-authored-by: Diego Vargas <[email protected]> Co-authored-by: Suren <[email protected]> Co-authored-by: mahmoud adel <[email protected]>

mahmoudadel54 added New Feature used for new functionalities C040-COMUNE_GE-2023-CUSTOM-SUPPORT labels Nov 10, 2023

mahmoudadel54 added this to the 2024.01.00 milestone Nov 10, 2023

mahmoudadel54 requested a review from MV88 November 10, 2023 13:43

mahmoudadel54 self-assigned this Nov 10, 2023

mahmoudadel54 added 2 commits November 13, 2023 13:04

Merge branch 'master' into feature_9683

e8cdef9

geosolutions-it#9683: resolve the FE test

b6edd57

Update DashboardEditor.jsx

MV88 requested changes Nov 13, 2023

View reviewed changes

tdipisa linked an issue Nov 14, 2023 that may be closed by this pull request

Details panel for MS dashboards #9683

Closed

3 tasks

mahmoudadel54 added 4 commits November 15, 2023 13:21

geosolutions-it#9683: remove unused comments in dashboard-test file

c71fab5

Merge branch 'feature_9683' of https://github.com/mahmoudadel54/MapSt…

0376bad

…ore2 into feature_9683

geosolutions-it#9683: edit in details epics and selectors to fix FE test

b737bd8

mahmoudadel54 requested a review from MV88 November 15, 2023 14:17

MV88 requested changes Nov 17, 2023

View reviewed changes

web/client/components/layout/BorderLayout.jsx Outdated Show resolved Hide resolved

geosolutions-it#9683: Resolve review comments

b0bad21

Description: - Reolve unused loading property from DashoardEditor file - Add tooltip for save dashboard - Remove custom style in BorderLayout and leave it with generic style

geosolutions-it#9683: resolve review comments

e8d7303

Description: - edit navbar.less files to fix going language selector behind body panel - remove unused z-index in dashboard.less

mahmoudadel54 requested a review from MV88 November 20, 2023 10:58

MV88 approved these changes Nov 21, 2023

View reviewed changes

MV88 merged commit d40233d into geosolutions-it:master Nov 21, 2023
4 checks passed

MV88 added the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Nov 24, 2023

mahmoudadel54 mentioned this pull request Nov 27, 2023

[Backport C040-2023.02.xx] #9683: add Details Panel for MS dashboard (#9689, #9730, #9740) #9750

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#9683: add Details Panel for MS dashboard #9689

#9683: add Details Panel for MS dashboard #9689

mahmoudadel54 commented Nov 10, 2023 •

edited

Loading

MV88 left a comment

MV88 left a comment

mahmoudadel54 commented Nov 20, 2023 •

edited

Loading

MV88 commented Nov 20, 2023

MV88 commented Nov 21, 2023

ElenaGallo commented Nov 22, 2023

MV88 commented Nov 24, 2023

mahmoudadel54 commented Nov 27, 2023

#9683: add Details Panel for MS dashboard #9689

#9683: add Details Panel for MS dashboard #9689

Conversation

mahmoudadel54 commented Nov 10, 2023 • edited Loading

Description

Issue

Breaking change

MV88 left a comment

Choose a reason for hiding this comment

MV88 left a comment

Choose a reason for hiding this comment

mahmoudadel54 commented Nov 20, 2023 • edited Loading

MV88 commented Nov 20, 2023

MV88 commented Nov 21, 2023

ElenaGallo commented Nov 22, 2023

MV88 commented Nov 24, 2023

mahmoudadel54 commented Nov 27, 2023

mahmoudadel54 commented Nov 10, 2023 •

edited

Loading

mahmoudadel54 commented Nov 20, 2023 •

edited

Loading