Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Widgets Catalog - format refresh does not work #9729

Closed
1 task done
MV88 opened this issue Nov 22, 2023 · 0 comments · Fixed by #9733 or #9747
Closed
1 task done

Widgets Catalog - format refresh does not work #9729

MV88 opened this issue Nov 22, 2023 · 0 comments · Fixed by #9733 or #9747
Assignees
@MV88 @ElenaGallo
Labels
Accepted bug C027-COMUNE_FI-2023-SUPPORT Widgets
Milestone
2023.02.01

Comments

@MV88
Copy link
Contributor

MV88 commented Nov 22, 2023

Description

the request to fetch format is not done because:

  • missing connections of formatOptionsFetch and showFormatError in catalogEditorEnhancer
  • there is an epic tied to the catalog plugin which is not imported in dashboard, it should move at app level maybe, or in baseEpics?
  • no issue in geostory catalog in edit mode of a map

How to reproduce

  • open a new dashboard
  • select chart
  • go in edit mode of the catalog
  • select csw type
  • expand advanced settings
  • click refresh button

Expected Result

if you are using gs stable url it should behave as in the viewer

Current Result

nothing happens, fields stay empty also the error is not shown in case of wrong url

  • Not browser related
Browser info (use this site: https://www.whatsmybrowser.org/ for non expert users)
Browser Affected Version
Internet Explorer
Edge
Chrome
Firefox
Safari

Other useful information
@MV88 MV88 added the bug label Nov 22, 2023
@tdipisa tdipisa added this to the 2023.02.01 milestone Nov 22, 2023
MV88 added a commit to MV88/MapStore2 that referenced this issue Nov 22, 2023
@MV88
Fix geosolutions-it#9729 fixed formats in catalog used in dashboard
49685c9 
* when used inside dasbhaord the fill of supported formats always ends up in
* the newService part of the catalog reducer, so i have used a dedicated selector
* for picking this info in the catalogEditorEnhancer
@MV88 MV88 added the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Nov 22, 2023
@MV88 MV88 mentioned this issue Nov 22, 2023
Merged
12 tasks
allyoucanmap pushed a commit that referenced this issue Nov 23, 2023
@MV88
Fix #9729 fixed formats in catalog used in dashboard (#9733)
05003d0
@ElenaGallo ElenaGallo self-assigned this Nov 24, 2023
@MV88 MV88 mentioned this issue Nov 24, 2023
Merged
5 tasks
MV88 added a commit to MV88/MapStore2 that referenced this issue Nov 24, 2023
@MV88
Fix geosolutions-it#9729 fixed formats in catalog used in dashboard (g…
b85e57f 
…eosolutions-it#9733)

# Conflicts:
#	web/client/epics/__tests__/config-test.js
@MV88 MV88 mentioned this issue Nov 24, 2023
Merged
allyoucanmap pushed a commit that referenced this issue Nov 24, 2023
@MV88
Fix #9729 fixed formats in catalog used in dashboard (#9733) (#9747)
a188d8a
@ElenaGallo ElenaGallo linked a pull request Nov 24, 2023 that will close this issue
backport 2023.02.xx - Fix #9729 fixed formats in catalog used in dashboard (#9733) #9747
Merged
@ElenaGallo ElenaGallo added Accepted and removed BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch labels Nov 24, 2023
tdipisa pushed a commit that referenced this issue Nov 27, 2023
@MV88 @allyoucanmap
@diegovargasg @dsuren1 @mahmoudadel54
updating stable branch of genova (#9748)
e257122 
* Fix #9624 Point cloud shading options (#9666)

* Fix #9666 Include pointCloudShading option to saved layer config (#9670)

* #9606 Error with circle annotations + radius selection (#9607) (#9727)

Co-authored-by: Diego Vargas <[email protected]>

* Fix #9295 added better handling of format in csw service (#9712) (#9732)

* #9702: Fix - Background selector in contexts won't retain thumbnail in view mode (#9720) (#9744)

* #9567: handle functionality of zoom to record in table widgets (#9608)

* #9567: handle functionality of zoom to record in table widgets

* Fix: Correct failing test cases for zoom records issue in table widgets (#9567)
This commit addresses the failing test cases related to the issue of zoom records in table widgets.
* #9567: implement the new approach in zoom to records in table widgets + writing unit tests
* #9567: handle adding flag into config file to show/hide zoom icon for tblWidget
* #9567: reset flag enableZoomInTblWidget to be true for dashboard and map viewer
* #9567: resolve comments' review:
- put flag of zoomInTblWidget as a default prop
- add translations
- edit zoomToExtent enhancer to use internal zoom
- remove selector "getFlagOfShowingTblWidgetZoom " and use plugin prop instead

* #9683: add Details Panel for MS dashboard (#9689)

* #9683: add Details Panel for MS dashboard
-  The tool have the same options (eg. show as modal, show at startup etc.)
- The tool is defined in the same way of the corresponding one for maps.
- Edit the layout to put add widget & show/hide connection buttons to the sidebar menu

* #9683: resolve the FE test

Update DashboardEditor.jsx

* #9683: resolve review comments
* description:
- remove all dashboard selectors and pieces of code in generic components like sidebar plugin component that relevant to dashboard.
- add missing test for detailsLoaded action
- create new selectors, details uri selector and details settings se;ector that are used in many places in code
- move AddWidgetDashboard, MapConnedctionDashboard plugins to direct plugins folder
- Put global spinner in details plugin and remove it from sidebar plugin
-  edit in handleSave enhancer file to make update attributes of details just implemented for Map and Dashboard
- Add custom style in details.less as the lib of react-dock doesn't allow to override left css property
- remove unused added style from panels.less

* #9683: remove unused comments in dashboard-test file

* #9683: edit in details epics and selectors to fix FE test

* #9683: Resolve review comments
Description:
- Reolve unused loading property from DashoardEditor file
- Add tooltip for save dashboard
- Remove custom style in BorderLayout and leave it with generic style

* #9683: resolve review comments
Description:
- edit navbar.less files to fix going language selector behind body panel
- remove unused z-index in dashboard.less
# Conflicts:
#	web/client/epics/__tests__/config-test.js
#	web/client/epics/config.js

* #9683: resolve test comment (#9730)

- Adding export, import, delete dashboard
- Reorder shown plugins in sidebar for dashboard

* #9683: add Details Panel for MS dashboard [Editing the detail panel tooltip and title]  (#9740)

* #9683: resolve test comment
Description:
- edit the detail panel tooltip and shown title and make it generic one
- Add translations for the new tooltip

* Update web/client/translations/data.it-IT.json

---------

Co-authored-by: Matteo V <[email protected]>

* #9728 fix misalignement issue (#9731) (#9742)

* Fix #9729 fixed formats in catalog used in dashboard (#9733) (#9747)

---------

Co-authored-by: stefano bovio <[email protected]>
Co-authored-by: Diego Vargas <[email protected]>
Co-authored-by: Suren <[email protected]>
Co-authored-by: mahmoud adel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MV88 MV88

@ElenaGallo ElenaGallo

Labels
Accepted bug C027-COMUNE_FI-2023-SUPPORT Widgets
Projects
None yet
Milestone
2023.02.01
3 participants
@tdipisa @MV88 @ElenaGallo