#8757 Increase waitFor timeout in cesium map test #8771
Merged
+3
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allyoucanmap
added
bug
Internal
BackportNeeded
offtherailz
approved these changes
Nov 3, 2022
There was a problem hiding this comment.
LGTM, waitFor has an internal timeout default to 1000ms, so if ref.map.dataSourceDisplay.ready takes longer to become true, it may fail. Applying the fix should avoid the test to fail.
This failure found on master branch looks consistent with the hypothesis and the fix applied. https://github.com/geosolutions-it/MapStore2/actions/runs/3385099330/jobs/5622852747
allyoucanmap
added a commit
to allyoucanmap/MapStore2
that referenced
this pull request
Nov 3, 2022
|
backported in #8770 |
allyoucanmap
removed
the
BackportNeeded
allyoucanmap
added a commit
to allyoucanmap/MapStore2
that referenced
this pull request
Nov 3, 2022
dsuren1
pushed a commit
that referenced
this pull request
Nov 3, 2022
…p click in 3D viewer (#8750) (#8770) * #8706 Restore multiple features selection on map click in 3D viewer (#8750) * restore multiple features selection on map click in 3D viewer * add bring to front on default style for points * increase timeout for failing test (#8756) * #8757 Increase waitFor timeout in cesium map test (#8771) * add cesium simulate test utils
tdipisa
pushed a commit
that referenced
this pull request
Nov 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Increase waitFor timeout in cesium map test
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
What is the current behavior?
#8757
What is the new behavior?
Increase waitFor timeout in cesium map test
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information