Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#8706 Restore multiple features selection on map click in 3D viewer #8750

Merged
merged 2 commits into from
Oct 31, 2022
Merged

#8706 Restore multiple features selection on map click in 3D viewer #8750

merged 2 commits into from
Oct 31, 2022

Conversation

allyoucanmap
Copy link
Contributor

Description

This PR restores the drill pick method in the click event of the map to return all the intersected features and not only the first one

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix

Issue

What is the current behavior?

#8706 see #8700 (comment)

What is the new behavior?

All the intersected features will be detected in the click event so they will be visible in GFI

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • No

Other useful information

@allyoucanmap allyoucanmap self-assigned this Oct 31, 2022
@allyoucanmap allyoucanmap requested a review from dsuren1 October 31, 2022 10:20
dsuren1
dsuren1 requested changes Oct 31, 2022
View reviewed changes
Copy link
Contributor

@dsuren1 dsuren1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@allyoucanmap
Looks good. However the clicked point is sometimes hidden behind the layers. This makes it hard to find the features being queried. Your thoughts?

From the screenshot, the clicked point is hidden (where the mouse pointer is present)
image

image

@allyoucanmap
Copy link
Contributor Author

allyoucanmap commented Oct 31, 2022 •
edited
Loading

@allyoucanmap Looks good. However the clicked point is sometimes hidden behind the layers. This makes it hard to find the features being queried. Your thoughts?

@dsuren1 I added a fix to force the bring to front option to point default styles but this will work only if existing point marker on map are not using bring to front. I'm going to add your comment to this issue #8749 (comment) so we can discuss also there on how to better highlight the features

@allyoucanmap allyoucanmap mentioned this pull request Oct 31, 2022
Open
1 task
@allyoucanmap allyoucanmap requested a review from dsuren1 October 31, 2022 14:17
@dsuren1 dsuren1 merged commit 8447568 into geosolutions-it:master Oct 31, 2022
@dsuren1
Copy link
Contributor

dsuren1 commented Oct 31, 2022

@ElenaGallo Kindly test in DEV and let us know if it can be backported. Thanks!

@ElenaGallo
Copy link
Contributor

Test passed, @allyoucanmap please backport

@tdipisa tdipisa added the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Oct 31, 2022
allyoucanmap added a commit to allyoucanmap/MapStore2 that referenced this pull request Nov 3, 2022
@allyoucanmap
geosolutions-it#8706 Restore multiple features selection on map click…
339335d 
… in 3D viewer (geosolutions-it#8750)

* restore multiple features selection on map click in 3D viewer

* add bring to front on default style for points
@allyoucanmap allyoucanmap removed the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Nov 3, 2022
dsuren1 pushed a commit that referenced this pull request Nov 3, 2022
@allyoucanmap
[Backport 2022.02.xx] #8706 Restore multiple features selection on ma…
5ab4dda 
…p click in 3D viewer (#8750) (#8770)

* #8706 Restore multiple features selection on map click in 3D viewer (#8750)

* restore multiple features selection on map click in 3D viewer

* add bring to front on default style for points

* increase timeout for failing test (#8756)

* #8757 Increase waitFor timeout in cesium map test (#8771)

* add cesium simulate test utils
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsuren1 dsuren1 dsuren1 approved these changes

Assignees

@allyoucanmap allyoucanmap

Labels
bug C040-COMUNE_GE-2022-CUSTOM-SUPPORT
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@allyoucanmap @dsuren1 @ElenaGallo @tdipisa