-
Notifications
You must be signed in to change notification settings - Fork 410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#7108, #7119: Improve Geocarousel section #7130
#7108, #7119: Improve Geocarousel section #7130
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @allyoucanmap
Changes with respect to draw support and background works fine.
However I did see few change in behavior with respect to carousel card component update which needs to looked into and possibly needs a fix
- Clicking on carousel card again with map's zoom and position changed, doesn't reset to it's initial position when marker added (is this behavior replaced with map fit feature now ?) cc @tdipisa @allyoucanmap
- Adding new item, the carousel widget is not scrolled to the added item
- Scroll event on carousel card item is propagated to other components
- Also carousel item navigation with arrow keys is missing in the new geo carousel widget
- Infocard position is misaligned due to recent change
- After deleting an item in carousel, unable to select other items after the deleted item in list
- Selecting the card's footer toolbar icons, triggers card selection too (Is this behavior fine? cc @tdipisa)
web/client/components/geostory/common/hooks/useSwipeControls.js
Outdated
Show resolved
Hide resolved
web/client/components/geostory/common/enhancers/withPopupSupport.jsx
Outdated
Show resolved
Hide resolved
web/client/components/geostory/common/enhancers/withPopupSupport.jsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Suren <[email protected]>
…rt.jsx Co-authored-by: Suren <[email protected]>
Co-authored-by: Suren <[email protected]>
…rt.jsx Co-authored-by: Suren <[email protected]>
Hi @dsuren1,
yes, the new behaviour follow the fit feature workflow
The issue was referring to the arrows in the UI so for now we don't need an implementation for keyboard |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Selecting the card's footer toolbar icons, triggers card selection too (Is this behavior fine? cc @tdipisa)
Happens with delete icon (Edit doesn't trigger the selection )
- Popup support needs to be disabled when drawing, as it interferes with the draw displaying popup after placing the marker
- Small cosmetic, just so we know, in mobile view having two geocarousel section one after another, displays the second carousel widget partially in the bottom
- Infocard position is misaligned due to recent change
Info card style needs to be adjusted
Apart from these, the fixes works fine.
@dsuren1 done apart of this. Now the implementation uses position sticky so it's the default behaviour I would discuss before with @tdipisa but I don't think is a blocker. We will open a new issue if needed |
LGTM :) |
Description
This PR improve the carousel sections of GeoStory by:
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
What is the current behavior?
#7108
#7119
What is the new behavior?
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information