Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Geocarousel section #7108

Closed
7 tasks done
dsuren1 opened this issue Jul 15, 2021 · 2 comments
Closed
7 tasks done

Improve Geocarousel section #7108

dsuren1 opened this issue Jul 15, 2021 · 2 comments

Comments

@dsuren1
Copy link
Contributor

dsuren1 commented Jul 15, 2021

Description

Improvements:

  • Improve the user experience in edit mode. The height of the column is increased every time the user adds a new content and that's fine but, if the column has a lot of contents in it, the carousel (the list of items) disappear from the screen: we should keep it always visible to provide a better UX in editing the GeoCarousel section. In view mode it is fine to maintain a fixed height with a scrolbar (as it is now)

What requested could be implemented using a sticky position of the carousel div, eg:

.ms2 .ms-cascade-story .ms-section .ms-section-carousel {
    margin: 0 auto;
    overflow-x: clip;
    padding: 0;
    **position: sticky;**
    **bottom: 0px;**
    **z-index: 5;**
}

carousel_1

  • if the title is missing the popup should not be visible

image

  • improve the draw marker UX with some message to explain that a user need to click on the map

image

  • Improve UX with tooltip message to inform upon adding new geocarousel section

2021-07-15_183436

Refer: #7095 (review)

What kind of improvement you want to add? (check one with "x", remove the others)

  • Minor changes to existing features
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)

Other useful information

@dsuren1
Copy link
Contributor Author

dsuren1 commented Jul 15, 2021

Hi @ElenaGallo The above improvements will be a handled as part of this issue reported in #7095 (review). Kindly consider this as you test #6993

@dsuren1 dsuren1 added the bug label Jul 16, 2021
@dsuren1
Copy link
Contributor Author

dsuren1 commented Jul 16, 2021

Tracking testing issues reported as part of #6993 in this issue
#6993 (comment)
#6993 (comment) (Not a bug)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants