Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #4035 Not easy to scroll dashboards on mobile #4115

Merged
merged 2 commits into from
Aug 30, 2019
Merged

Fix #4035 Not easy to scroll dashboards on mobile #4115

merged 2 commits into from
Aug 30, 2019

Conversation

vlt1
Copy link
Contributor

@vlt1 vlt1 commented Aug 28, 2019 •
edited by tdipisa
Loading

Description

If the app is run on mobile, a space is added on the right side for a scroll

Issues

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

@vlt1 vlt1 added this to the 2019.02.01 milestone Aug 28, 2019
@tdipisa tdipisa requested a review from allyoucanmap August 28, 2019 16:10
allyoucanmap
allyoucanmap requested changes Aug 29, 2019
View reviewed changes
Copy link
Contributor

@allyoucanmap allyoucanmap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix seems good,
could you provide a unit test for this change?

@coveralls
Copy link

coveralls commented Aug 30, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-0.03%) to 82.177% when pulling e6a6b56 on vlt1:fix/4035 into 66e3435 on geosolutions-it:master.

@tdipisa tdipisa merged commit e16faab into geosolutions-it:master Aug 30, 2019
@tdipisa
Copy link
Member

tdipisa commented Aug 30, 2019

@vlt1 can you please backport this to 2019.02.xx stable branch?

vlt1 added a commit to vlt1/MapStore2 that referenced this pull request Aug 30, 2019
@vlt1
Fix geosolutions-it#4035 Not easy to scroll dashboards on mobile (geo…
904b908 
…solutions-it#4115)

* fix geosolutions-it#4035

* tests added

(cherry picked from commit e16faab)
tdipisa pushed a commit that referenced this pull request Aug 30, 2019
@vlt1
Fix #4035 Not easy to scroll dashboards on mobile (#4115) (#4120)
ede9848 
* fix #4035

* tests added

(cherry picked from commit e16faab)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allyoucanmap allyoucanmap allyoucanmap approved these changes

Assignees

@vlt1 vlt1

Labels
None yet
Projects
None yet
Milestone
2019.02.01
Development

Successfully merging this pull request may close these issues.
5 participants
@vlt1 @coveralls @tdipisa @allyoucanmap @shatvl