Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not easy to scroll dashboards on mobile #4035

Closed
offtherailz opened this issue Aug 2, 2019 · 2 comments
Closed

Not easy to scroll dashboards on mobile #4035

offtherailz opened this issue Aug 2, 2019 · 2 comments

Comments

@offtherailz
Copy link
Member

Description

If you have many widgets that have some sort of internal scroll or drag events (map, tables) and you can edit the dashboard is very hard to stroll, because touch events are captured by the widgets (scrolling the table, moving map, dragging widgets)
widgets-mobile

A possible solution is to add a small margin on the right to allow to scroll easy by using it.

In case of Bug (otherwise remove this paragraph)

Browser Affected
tested on chrome mobile.

Steps to reproduce

  • Open a dashboard like (this)[http://dev.mapstore2.geo-solutions.it/mapstore/#/dashboard/5652] where you have edit permissions (with widgets like table or map)
  • try to scroll up and down with the finger

Expected Result

  • It should be easy to find a way to scroll widgets

Current Result

  • It's hard to find out a point on the viewport to activate scroll.
@vlt1
Copy link
Contributor

vlt1 commented Aug 27, 2019

@tdipisa @offtherailz
I suggest to add margin-top/bottom between widgets for mobile devices.
What do you think about it?

@tdipisa
Copy link
Member

tdipisa commented Aug 27, 2019

@vlt1

I suggest to add margin-top/bottom between widgets for mobile devices.
What do you think about it?

we wouldn't like to add other margin betweek widgets, if adding some margin on the right solves the issue is enough for us.

vlt1 pushed a commit to vlt1/MapStore2 that referenced this issue Aug 28, 2019
@tdipisa tdipisa reopened this Aug 30, 2019
vlt1 added a commit to vlt1/MapStore2 that referenced this issue Aug 30, 2019
tdipisa pushed a commit that referenced this issue Aug 30, 2019
* fix #4035

* tests added

(cherry picked from commit e16faab)
@francoxyz francoxyz self-assigned this Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants