Fixes #2522 Embed doesn't work anymore (RELEASE 2017.06.00) #2538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
allyoucanmap
changed the title
4 tasks
offtherailz
requested changes
Jan 19, 2018
web/client/reducers/version.js
Outdated
| case LOAD_VERSION_ERROR: { | ||
| return assign({}, state, | ||
| { | ||
| current: '${mapstore2.version.error}' |
There was a problem hiding this comment.
no-version, without ${}. This should be enough
|
Question: Is versioning documented somewhere? |
offtherailz
approved these changes
Jan 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added versioning to API and embedded to load mapstore theme.
Issues
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
What is the current behavior? (You can also link to an open issue here)
Issue #2522
What is the new behavior?
Now embedded and API are versioned and the theme correctly loaded
Does this PR introduce a breaking change? (check one with "x", remove the other)
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information:
Need to update project configuration (app.jsx, embedded.jsx, api.jsx) if versioning is required