Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Embed doesn't work anymore #2522

Closed
offtherailz opened this issue Jan 16, 2018 · 0 comments
Closed

Embed doesn't work anymore #2522

offtherailz opened this issue Jan 16, 2018 · 0 comments
Assignees
@allyoucanmap @chiaracurcio
Labels
Accepted bug Priority: Blocker
Milestone
2018.01.00 Hardening

Comments

@offtherailz
Copy link
Member

offtherailz commented Jan 16, 2018 •
edited by allyoucanmap
Loading

Description

Look at this this and this
Embed seems to not load style correctly (probably due to recent changes in build (e.g. theme versioning)

In case of Bug (otherwise remove this paragraph)

Browser Affected
any

Steps to reproduce

  • Open the embed link or the API example in dev

Expected Result

  • You see the embedded version of the map
  • emebedd should be versioned on js and default.css (MapStore2 theme)
  • API should be versioned on js and default.css (MapStore2 theme)
  • Share plugin should show versioned ms2-api.js in textarea
  • Check styles of examples

Current Result

  • You see some not working tool, with default bootstrap style
@offtherailz offtherailz added this to the 2017.06.00 Hardening milestone Jan 16, 2018
This was referenced Jan 18, 2018
Closed
Merged
offtherailz pushed a commit that referenced this issue Jan 19, 2018
@allyoucanmap @offtherailz
Fixes #2522 Embed doesn't work anymore (#2538)
5c7b0e1
@offtherailz offtherailz mentioned this issue Jan 19, 2018
Merged
@ghost ghost added the Accepted label Jan 19, 2018
@chiaracurcio chiaracurcio reopened this Jan 22, 2018
@chiaracurcio chiaracurcio self-assigned this Jan 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@allyoucanmap allyoucanmap

@chiaracurcio chiaracurcio

Labels
Accepted bug Priority: Blocker
Projects
None yet
Milestone
2018.01.00 Hardening
Development

Successfully merging a pull request may close this issue.

Fixes #2522 Embed doesn't work anymore allyoucanmap/MapStore2
4 participants
@offtherailz @tdipisa @allyoucanmap @chiaracurcio