Fix #10489 Problems with GeoStory map configurations merge process #10438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Description: - fix issue of reset legend filter within map configure panel in geostory - edit unit test due to changes
1 task
allyoucanmap
requested changes
Jul 4, 2024
…resolve reviews) Description: - add unit test for layers key - refactor createMapObject method based on the new review
allyoucanmap
requested changes
Jul 24, 2024
There was a problem hiding this comment.
@tdipisa @mahmoudadel54 This fix should take into account also the problem described in this other issue #10489.
I'm going to change the title of PR and connect it to the new issue
allyoucanmap
changed the title
3 tasks
1 task
1 task
@mahmoudadel54 can you please proceed as requested above providing an estimate before? |
3 tasks
…e process [resolve review comment] Description: - handle legacy geostory map configurations merge process - add unit tests
allyoucanmap
approved these changes
Aug 8, 2024
|
@ElenaGallo please test this fix on dev, thanks |
1 task
This was referenced Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR, fixing issue of reset legend filter within map configure panel in geostory is implemented. Now in geostories, if the interactive legend is enabled and set on a new map, it is possible to edit it correctly on the map inline panel.
The issue is mentioned here: #10426 (comment)
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
#10426 (comment)
Also involved #10489
What is the current behavior?
#10426 (comment)
What is the new behavior?
In geostories, if the interactive legend is enabled and set on a new map, it is Ok to edit it correctly on the map inline panel without any non expected behavior.
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information