Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Interactive legend in dashboard and geostory #10235

Closed
1 task done
allyoucanmap opened this issue Apr 23, 2024 · 0 comments · Fixed by #10426
Closed
1 task done

Interactive legend in dashboard and geostory #10235

allyoucanmap opened this issue Apr 23, 2024 · 0 comments · Fixed by #10426
Assignees
@ElenaGallo @mahmoudadel54
Labels
Accepted C040-COMUNE_GE-2023-CUSTOM-SUPPORT enhancement
Milestone
2024.02.00

Comments

@allyoucanmap
Copy link
Contributor

allyoucanmap commented Apr 23, 2024 •
edited by mahmoudadel54
Loading

Description

We need to add the interactive legend behavior also in dashboard.
Expected implementations:

  • include the layerFilter among the properties updated by the legend widget (Note: probably it's enough to pass the layerFilter here)
  • fix the wrong behaviour of the TOC for map widgets where the legend is restored to default configuration (see video)
edit-style-with-filter.mp4

It is also required to add the interactive legend behavior for geostory as well

What kind of improvement you want to add? (check one with "x", remove the others)

  • Minor changes to existing features

Other useful information
@allyoucanmap allyoucanmap added this to the 2024.02.00 milestone Apr 23, 2024
@tdipisa tdipisa mentioned this issue Apr 23, 2024
Merged
12 tasks
@mahmoudadel54 mahmoudadel54 changed the title Interactive legend in dashboard Interactive legend in dashboard and geostory Apr 24, 2024
@tdipisa tdipisa assigned mahmoudadel54 and unassigned tdipisa May 7, 2024
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Jun 13, 2024
@mahmoudadel54
geosolutions-it#10235: Interactive legend in dashboard and geostory
407112b 
Description:
- handle showing interactive legend option for dashboard and geostory
- handle saving layerFilter for dashboard and geostory
- add unit test
- add refactoring to StyleBasedWMSJsonLegend
@mahmoudadel54 mahmoudadel54 mentioned this issue Jun 14, 2024
Merged
12 tasks
@mahmoudadel54 mahmoudadel54 linked a pull request Jun 14, 2024 that will close this issue
#10235: Interactive legend in dashboard and geostory #10426
Merged
12 tasks
allyoucanmap pushed a commit that referenced this issue Jun 17, 2024
@mahmoudadel54
#10235: Interactive legend in dashboard and geostory (#10426)
03ea83e
@ElenaGallo ElenaGallo self-assigned this Jun 17, 2024
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Jun 21, 2024
@mahmoudadel54
geosolutions-it#10235: Interactive legend in dashboard and geostory
b950b02 
Description:
- fix issue of reset legend filter within map configure panel in geostory
- edit unit test due to changes
@mahmoudadel54 mahmoudadel54 linked a pull request Jun 21, 2024 that will close this issue
Fix #10489 Problems with GeoStory map configurations merge process #10438
Merged
12 tasks
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Jul 8, 2024
@mahmoudadel54
geosolutions-it#10235: Interactive legend in dashboard and geostory (…
c575d40 
…resolve reviews)

Description:
- add unit test for layers key
- refactor createMapObject method based on the new review
@allyoucanmap allyoucanmap removed a link to a pull request Jul 24, 2024
Fix #10489 Problems with GeoStory map configurations merge process #10438
Merged
12 tasks
@tdipisa tdipisa reopened this Jul 24, 2024
@tdipisa tdipisa linked a pull request Jul 24, 2024 that will close this issue
Fix #10489 Problems with GeoStory map configurations merge process #10438
Merged
12 tasks
@tdipisa tdipisa closed this as completed Jul 24, 2024
@tdipisa tdipisa reopened this Jul 24, 2024
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Aug 1, 2024
@mahmoudadel54
geosolutions-it#10235: Problems with GeoStory map configurations merg…
2309236 
…e process [resolve review comment]

Description:
- handle legacy geostory map configurations merge process
- add unit tests
@tdipisa tdipisa removed a link to a pull request Aug 19, 2024
Fix #10489 Problems with GeoStory map configurations merge process #10438
Merged
12 tasks
@ElenaGallo ElenaGallo mentioned this issue Sep 16, 2024
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ElenaGallo ElenaGallo

@mahmoudadel54 mahmoudadel54

Labels
Accepted C040-COMUNE_GE-2023-CUSTOM-SUPPORT enhancement
Projects
None yet
Milestone
2024.02.00
Development

Successfully merging a pull request may close this issue.

#10235: Interactive legend in dashboard and geostory mahmoudadel54/MapStore2
4 participants
@tdipisa @allyoucanmap @ElenaGallo @mahmoudadel54