-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#10414: Remove the list of associated groups of logged in user from the User Details modal window #10415
Conversation
… in user from the User Details modal window Description: - handle hide group info in user details modal by adding a cfg in Login plugin 'hideGroupUserInfo' - add unit test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
your solutions works only because the user details is the first in the list of tools, but if a project has a custom login plugin this might not work, so I think you have to specify this information as well. Probably it should be mentioned in the migration guidelines because it could be a breaking change in a sense that this configuration may not work there if there are refactors to the login plugin. the index part is import to highlight.
- please add this entry in the migration guidelnes
- improve tests
web/client/components/security/modals/__tests__/UserDetailsModal-test.jsx
Outdated
Show resolved
Hide resolved
web/client/components/security/modals/__tests__/UserDetailsModal-test.jsx
Outdated
Show resolved
Hide resolved
… in user from the User Details modal window Description: - add migration guide notes related to the PR changes - edit in unit tests
… in user from the User Details modal window Description: - Merge branch 'master' into enhance_10414 with fix conflicts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make sure to run locally documentation to check possible syntax errror
… in user from the User Details modal window Description: - resolve review comments related to edits in migration file
@ElenaGallo please test in DEV and let us know if we can backport. |
@tdipisa even the admin can't see the GroupUserInfo section, is this correct? |
I've commented here: Something that has not been reported in the ACs. @mahmoudadel54 can you please take a look? Can we do that simply by config or dev is necessary for it? |
Ok I will take a look for it Is it required to make it optional based on config to show or hide group for admin ? Or group should be shown by default for admin without using config? @tdipisa |
@mahmoudadel54 thank you for this check. Let's leave this as it is now since it is not so fundamental and the config you have provided is not the default one. @ElenaGallo if there is nothing else we can we can ask @mahmoudadel54 to backport. |
Test passed, @mahmoudadel54 please backport to 2024.01.xx |
backport is done ---> #10447 |
Description
In this PR, handling hiding the group info in the user details modal by adding a cfg in Login plugin 'hideGroupUserInfo' is implemented. If 'hideGroupUserInfo' is configured into Login plugin cfg,
{ "name": "Login", "cfg": { "toolsCfg": [{"hideGroupUserInfo": true}] } }
the group info into user details modal will not be shown.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
#10414
What is the current behavior?
#10414
What is the new behavior?
If 'hideGroupUserInfo' is configured into Login plugin cfg, the group info into user details modal will not be shown.
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information
For Login plugin (cfg.toolsCfg[0].hideGroupUserInfo) ---> the first index into toolsCfg is for userDetails tool based on this order as I think:
MapStore2/web/client/plugins/Login.jsx
Line 104 in bc4aefc
MapStore2/web/client/plugins/Login.jsx
Line 86 in bc4aefc