Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Share tool - the 'Add place mark and zoom to sharing link' option is not applied correctly #10418

Closed
1 task done
ElenaGallo opened this issue Jun 11, 2024 · 0 comments · Fixed by #10419 or #10435
Closed
1 task done

Share tool - the 'Add place mark and zoom to sharing link' option is not applied correctly #10418

ElenaGallo opened this issue Jun 11, 2024 · 0 comments · Fixed by #10419 or #10435
Assignees
@ElenaGallo @mahmoudadel54
Labels
Accepted bug C125-AUSTROCONTROL-2024-MapStore Priority: High Regression
Milestone
2024.01.02

Comments

@ElenaGallo
Copy link
Contributor

Description

Once the 'Add place mark and zoom to sharing link' option is enabled, and the Share tool closed, the marker is still visible on the map and the homepage button is no longer clickable.

How to reproduce

share.mp4
  • Not browser related
Browser info (use this site: https://www.whatsmybrowser.org/ for non expert users)
Browser Affected Version
Internet Explorer
Edge
Chrome
Firefox
Safari

Other useful information
@ElenaGallo ElenaGallo added this to the 2024.01.02 milestone Jun 11, 2024
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Jun 11, 2024
@mahmoudadel54
geosolutions-it#10418: Share tool - the 'Add place mark and zoom to s…
155acc8 
…haring link' option is not applied correctly

Description:
- fix a bug in search epic 'getFeatureInfoOfSelectedItem' that affects share tool
@mahmoudadel54 mahmoudadel54 mentioned this issue Jun 11, 2024
Merged
12 tasks
@mahmoudadel54 mahmoudadel54 linked a pull request Jun 11, 2024 that will close this issue
#10418: Share tool - the 'Add place mark and zoom to sharing link' option is not applied correctly #10419
Merged
12 tasks
@tdipisa tdipisa added the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Jun 12, 2024
allyoucanmap pushed a commit that referenced this issue Jun 17, 2024
@mahmoudadel54
#10418: Share tool - the 'Add place mark and zoom to sharing link' op…
b33f740 
…tion is not applied correctly (#10419)
@ElenaGallo ElenaGallo self-assigned this Jun 17, 2024
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Jun 20, 2024
@mahmoudadel54
geosolutions-it#10418: Share tool - the 'Add place mark and zoom to s…
35b6f07 
…haring link' option is not applied correctly (geosolutions-it#10419)
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Jun 20, 2024
@mahmoudadel54
geosolutions-it#10418: Share tool - the 'Add place mark and zoom to s…
83a0bdf 
…haring link' option is not applied correctly (geosolutions-it#10419)
@mahmoudadel54 mahmoudadel54 mentioned this issue Jun 20, 2024
Merged
@mahmoudadel54 mahmoudadel54 linked a pull request Jun 20, 2024 that will close this issue
[Backport 2024.01.xx]: #10418: Share tool - the 'Add place mark and zoom to sharing link' option is not applied correctly (#10419) #10435
Merged
tdipisa pushed a commit that referenced this issue Jun 24, 2024
@mahmoudadel54
#10418: Share tool - the 'Add place mark and zoom to sharing link' op…
5df8cb1 
…tion is not applied correctly (#10419) (#10435)
@tdipisa tdipisa removed the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Jun 24, 2024
tdipisa pushed a commit that referenced this issue Jun 28, 2024
@mahmoudadel54
[Backport 2024.01.xx]: #10414: Remove the list of associated groups o…
59ea05b 
…f logged in user from the User Details modal window (#10415) (#10447)

* #10418: Share tool - the 'Add place mark and zoom to sharing link' option is not applied correctly (#10419)

* backport #10414 with fix conflict in migration file

* fix migration conflict during merge
tdipisa pushed a commit that referenced this issue Jul 3, 2024
@mahmoudadel54 @offtherailz
[Backport 2024.01.xx] - #10322: Fix scale selector to make it compati…
8529d7d 
…ble with different projections (#10344) (#10452)

* #10418: Share tool - the 'Add place mark and zoom to sharing link' option is not applied correctly (#10419)

* #10322: Fix scale selector to make it compatible with different projections (#10344)

* #10322: Fix scale selector to make it compatible with different projections
Description:
- fix the bug by using the updated scaleZoom value instead of the projected value

* #10322: Fix scale selector to make it compatible with different projections
Description:
- add helpful comment

* #10322: Fix scale selector to make it compatible with different projections
Description:
- fix not compatablity projections issue
- add unit tests

* #10322: Fix scale selector to make it compatible with different projections
Description:
- resolve review comments related to unit tests [replace async/await with then + remove unnecessary async/await]

* #10322: Fix scale selector to make it compatible with different projections
Description:
- fix issues of not consistent map print scales with the current map view

* #10322: Fix scale selector to make it compatible with different projections
Description:
- fix FE issue

* Fixed preview

* #10322: Fix scale selector to make it compatible with different projections
Description:
- resolve FE failure due to changes

---------

Co-authored-by: Lorenzo Natali <[email protected]>

---------

Co-authored-by: Lorenzo Natali <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ElenaGallo ElenaGallo

@mahmoudadel54 mahmoudadel54

Labels
Accepted bug C125-AUSTROCONTROL-2024-MapStore Priority: High Regression
Projects
None yet
Milestone
2024.01.02
3 participants
@tdipisa @ElenaGallo @mahmoudadel54