Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improving readability of long attribute values in attribute table and table widgets #9553

Closed
1 of 6 tasks
tdipisa opened this issue Oct 3, 2023 · 4 comments · Fixed by #9701, #9719, #9793, #9794 or #9800
Closed
1 of 6 tasks

Improving readability of long attribute values in attribute table and table widgets #9553

tdipisa opened this issue Oct 3, 2023 · 4 comments · Fixed by #9701, #9719, #9793, #9794 or #9800
Assignees
@offtherailz @ElenaGallo
Labels
Accepted C040-COMUNE_GE-2023-CUSTOM-SUPPORT enhancement
Milestone
2023.02.01

Comments

@tdipisa
Copy link
Member

tdipisa commented Oct 3, 2023 •
edited
Loading

Description

For attribute values that are not entirely visible in the attribute table, show a tooltip to visualize the entire attribute value to the user when hovering over the value (for both view and edit mode).

Image

Also table widgets should be covered by this issue. The tooltip should appear only if necessary to ensure a good UX.

What kind of improvement you want to add? (check one with "x", remove the others)

  • Minor changes to existing features
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Other useful information
@tdipisa tdipisa self-assigned this Oct 3, 2023
@tdipisa tdipisa modified the milestones: 2024.01.00, 2023.02.02, 2023.02.01 Oct 11, 2023
@tdipisa tdipisa assigned mahmoudadel54 and unassigned tdipisa Nov 3, 2023
@mahmoudadel54
Copy link
Contributor

Hi @tdipisa
These are 2 demos one for map viewer and the other one for dashboard viewer demonstrating showing tooltip on table cells that has content longer than the cell width.

1st demo (map viewer):

add.tooltip.in.attr.tbl.mp4

2nd demo (dashboard):

add.tooltip.in.attr.tbl.in.dashboard.mp4

Is this acceptable for UX point of view ?

@MV88
Copy link
Contributor

MV88 commented Nov 14, 2023

@mahmoudadel54 yes looks great

mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Nov 14, 2023
@mahmoudadel54
geosolutions-it#9553: handle showing tooltip on attr table cells once…
5be7fab 
… user hovers on cell
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Nov 14, 2023
@mahmoudadel54
geosolutions-it#9553: create a separate enhnacer for handleLongText a…
f58b394 
…nd use it for formatter table cell
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Nov 14, 2023
@mahmoudadel54
geosolutions-it#9553: add copyright for the created handleLongTextEnh…
6817bdb 
…ancer
@tdipisa
Copy link
Member Author

tdipisa commented Nov 14, 2023

@mahmoudadel54 it looks really good.

mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Nov 14, 2023
@mahmoudadel54
geosolutions-it#9553: handle test cases for handleLongTextEnhancer
60f3eb5
@mahmoudadel54 mahmoudadel54 mentioned this issue Nov 14, 2023
Merged
12 tasks
@mahmoudadel54 mahmoudadel54 linked a pull request Nov 14, 2023 that will close this issue
#9553: Improving readability of long attribute values in attribute table and table widgets #9701
Merged
12 tasks
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Nov 15, 2023
@mahmoudadel54
geosolutions-it#9553: add unit tests for handleLongTextEnhancer
fc1e755
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Nov 15, 2023
@mahmoudadel54
geosolutions-it#9553: fix unit test failure for featureTypeToGridColu…
711c0c1 
…mns formatters
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Nov 15, 2023
@mahmoudadel54
geosolutions-it#9553:reset tests.webpack file
5d75eeb
MV88 added a commit that referenced this issue Nov 21, 2023
@mahmoudadel54 @MV88
#9553: Improving readability of long attribute values in attribute ta…
0716234 
…ble and table widgets (#9701)

* #9553: handle showing tooltip on attr table cells once user hovers on cell

* #9553: create a separate enhnacer for handleLongText and use it for formatter table cell

* #9553: add copyright for the created handleLongTextEnhancer

* #9553: handle test cases for handleLongTextEnhancer

* #9553: add unit tests for handleLongTextEnhancer

* #9553: fix unit test failure for featureTypeToGridColumns formatters

* #9553:reset tests.webpack file

* Update web/client/components/misc/enhancers/handleLongTextEnhancer.jsx

---------

Co-authored-by: Matteo V <[email protected]>
@MV88 MV88 added the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Nov 21, 2023
@ElenaGallo ElenaGallo assigned tdipisa and ElenaGallo and unassigned tdipisa Nov 21, 2023
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Nov 21, 2023
@mahmoudadel54 @MV88
geosolutions-it#9553: Improving readability of long attribute values …
b4448e3 
…in attribute table and table widgets (geosolutions-it#9701)

* geosolutions-it#9553: handle showing tooltip on attr table cells once user hovers on cell

* geosolutions-it#9553: create a separate enhnacer for handleLongText and use it for formatter table cell

* geosolutions-it#9553: add copyright for the created handleLongTextEnhancer

* geosolutions-it#9553: handle test cases for handleLongTextEnhancer

* geosolutions-it#9553: add unit tests for handleLongTextEnhancer

* geosolutions-it#9553: fix unit test failure for featureTypeToGridColumns formatters

* geosolutions-it#9553:reset tests.webpack file

* Update web/client/components/misc/enhancers/handleLongTextEnhancer.jsx

---------

Co-authored-by: Matteo V <[email protected]>
@mahmoudadel54 mahmoudadel54 mentioned this issue Nov 21, 2023
Merged
@mahmoudadel54 mahmoudadel54 linked a pull request Nov 21, 2023 that will close this issue
[Backport 2023.02.xx] #9553: Improving readability of long attribute values in attribute table and table widgets (#9701) #9719
Merged
MV88 added a commit that referenced this issue Nov 22, 2023
@mahmoudadel54 @MV88
#9553: Improving readability of long attribute values in attribute ta…
e654fba 
…ble and table widgets (#9701) (#9719)

* #9553: handle showing tooltip on attr table cells once user hovers on cell

* #9553: create a separate enhnacer for handleLongText and use it for formatter table cell

* #9553: add copyright for the created handleLongTextEnhancer

* #9553: handle test cases for handleLongTextEnhancer

* #9553: add unit tests for handleLongTextEnhancer

* #9553: fix unit test failure for featureTypeToGridColumns formatters

* #9553:reset tests.webpack file

* Update web/client/components/misc/enhancers/handleLongTextEnhancer.jsx

---------

Co-authored-by: Matteo V <[email protected]>
@tdipisa tdipisa modified the milestones: 2023.02.02, 2023.02.01 Nov 22, 2023
@tdipisa tdipisa removed the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Nov 22, 2023
@offtherailz offtherailz mentioned this issue Nov 28, 2023
Closed
1 task
@tdipisa tdipisa removed the Accepted label Dec 5, 2023
@tdipisa
Copy link
Member Author

tdipisa commented Dec 5, 2023 •
edited
Loading

I'm going to reopen this issue since there is a bug in editing for the Attribute Table for which it is not possible to enable the editing of an attribute if not double clicking on cell sides.

Image

@offtherailz possibly fix this in both dev and qa. If a quick and secure fix cannot be applied we have to revert this enhancement from the stable branch.

@offtherailz offtherailz mentioned this issue Dec 6, 2023
Merged
12 tasks
@ElenaGallo ElenaGallo linked a pull request Dec 6, 2023 that will close this issue
[Backport 2023.02.xx] Fix #9763. long string tooltip applied statically to components (#9793) #9794
Merged
@ElenaGallo ElenaGallo self-assigned this Dec 6, 2023
@mahmoudadel54 mahmoudadel54 linked a pull request Dec 7, 2023 that will close this issue
[Backport C040-2023.02.xx] Fix #9763. long string tooltip applied statically to components (#9793) #9800
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@offtherailz offtherailz

@ElenaGallo ElenaGallo

Labels
Accepted C040-COMUNE_GE-2023-CUSTOM-SUPPORT enhancement
Projects
None yet
Milestone
2023.02.01
5 participants
@offtherailz @tdipisa @MV88 @ElenaGallo @mahmoudadel54