Shorten the filename of the benchmark operations budget table #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yantosca
added
the
topic: Benchmark Plots and Tables
yantosca
added a commit
that referenced
this pull request
Jun 1, 2023
CHANGELOG.md - Add a sentence about passing label=None to the routine make_benchmark_operations_budget to shorten the name of the file that is created. This is only done in run_benchmark.py. Signed-off-by: Bob Yantosca <[email protected]>
lizziel
reviewed
Jun 2, 2023
|
I can try this @lizziel |
yantosca
force-pushed
the
feature/fix-ops-budget-filename
branch
from
97c64a1 to
21bb47c
Compare
gcpy/benchmark.py - Remove the "if label is not None" block, which was used to determine if the label argument should be appended to the file name. We now create the file name without using the label argument. CHANGELOG.md - Updated accordingly Signed-off-by: Bob Yantosca <[email protected]>
hannahnesser
pushed a commit
to hannahnesser/gcpy
that referenced
this pull request
Jan 22, 2024
This merge brings in PR geoschem#227 (by @yantosca) into the GCPy 1.4.0 development stream. It removes the long date string from the GCPy operations budget filename. The filename is now always called "Budgets_After_Operations.txt". Signed-off-by: Bob Yantosca <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the companion PR to issue #218. In
run_benchmark.pywe now passlabel=Noneto the routinemake_benchmark_operations_budgetso that the output file will be simplyBudgets_After_Operations.txt, without appending datetime strings.No further action needs to be taken for the 1-year benchmark scripts, as these already use shorter labels.
Closes #218