[Feature Request] Reduce length and remove space from budget operations table name

[lizziel]

Name: Lizzie Lundgren
Institution: Harvard University

The operations budget table name is very long and contains a space. For example:
Budgets_After_Operations_2019-07-01T00:00:00 - 2019-07-01T01:00:00.txt

The table could instead be named simply Budgets_After_Operations.txt, dropping the time interval strings. It is possible the time strings are needed if generating the budget from the 1-year benchmark but I am not sure. If it is, then we can come up with a more concise time string to append to the filename.

This is not urgent but something to address at some point.

[yantosca]

@lizziel: The budget string is computed here e.g. in run_benchmark.py:

        # ==================================================================
        # GCC vs GCC string for month and year
        # (e.g. "2019-07-01T00:00:00 - 2019-08-01T00:00:00")
        # ==================================================================
        if np.equal(gcc_ref_date, gcc_dev_date) and np.equal(
            gcc_end_ref_date, gcc_end_dev_date
        ):
            comparison_str = (
                f"{config['data']['dev']['gcc']['bmk_start']} "
                + f"- {config['data']['dev']['gcc']['bmk_end']}"
            )
        else:
            comparison_str = (
                f"{config['data']['dev']['gcc']['bmk_start']} "
                + f"- {config['data']['dev']['gcc']['bmk_end']}"
                + f" Vs {config['data']['ref']['gcc']['bmk_start']} "
                + f"- {config['data']['ref']['gcc']['bmk_end']}"
            )

and then passed to

            # Create table
            bmk.make_benchmark_operations_budget(
                config["data"]["ref"]["gcc"]["version"],
                ref,
                config["data"]["dev"]["gcc"]["version"],
                dev,
                gcc_ref_sec_diff,
                gcc_dev_sec_diff,
                benchmark_type=config["options"]["bmk_type"],
                label=comparison_str,   # <==== HERE
                dst=gcc_vs_gcc_tablesdir,

A quick fix would be to set label=None in all the calls to the make_benchmark_operations_budget routine. I can try this, and will doublecheck if we need to add a string in the 1-yr benchmark output to avoid clobbering these files.

[yantosca]

In the 1-year benchmark scripts it looks like we already have short filenames passed via label:

                 # Create tables
                bmk.make_benchmark_operations_budget(
                    config["data"]["dev"]["gcc"]["version"],
                    refpath,
                    config["data"]["dev"]["gchp"]["version"],
                    devpath,
                    bmk_sec_per_month_dev[m],
                    bmk_sec_per_month_dev[m],
                    benchmark_type=bmk_type,
                    label=f"at 01{bmk_mon_yr_strs_dev[m]}",
                    operations=[
                        "Chemistry",
                        "Convection",
                        "EmisDryDep",
                        "Mixing",
                        "WetDep",
                    ],
                    compute_accum=False,
                    dst=gchp_vs_gcc_tablesdir,

[yantosca]

PR #227 has now been merged, so we can close this issue.