Remove references to gcpy_test and gchp_is_pre_13_1 from benchmarking routines and config files #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benchmark/1mo_benchmark.yml benchmark/1yr_ch4_benchmark.yml benchmark/1yr_fullchem_benchmark.yml benchmark/1yr_tt_benchmark.yml - main_dir is now a placeholder path instead of path to gcpy_test_data - Added comments telling the user to edit paths as needed - Removed is_pre_13.1 tags from GCHP_ref and GCHP_dev entries benchmark/modules/run_1yr_fullchem_benchmark.py benchmark/modules/run_1yr/tt_benchmark.py benchmark/run_benchmark.py - Remove code resetting timestamps for GCHP versions prior to 13.1 - Remove gchp_is_pre_13_1 arguments from get_filepath and get_filepaths gcpy/util.py - Removed gchp_is_pre_13_1 arguments from get_filepath, get_filepaths Signed-off-by: Bob Yantosca <[email protected]>
benchmark/run_benchmark.py - Removed the if block that assigns the results directories based on whether gcpy_test was selected or not. - Removed comments about gcpy_test in header - Updated version to 1.4.0 in header comments benchmark/modules/run_*_benchmark.py - Removed comments about gcpy_test - Updated version to 1.4.0 in header comments Signed-off-by: Bob Yantosca <[email protected]>
yantosca
added
category: Feature Request
Signed-off-by: Bob Yantosca <[email protected]>
benchmark/cloud/template.1hr_benchmark benchmark/cloud/template.1mo_benchmark - Removed the is_pre_13.1 tags from ref & dev GCHP entries in these cloud benchmarking configuration files for consistency with the other configuration files. Signed-off-by: Bob Yantosca <[email protected]>
lizziel
requested changes
May 31, 2023
benchmark/run_benchmark.py - The "is_gchp=True" keyword argument needs to be followed by a comma (e.g. "is_gchp=True," as there are arguments that come after it. Now fixed. Signed-off-by: Bob Yantosca <[email protected]>
lizziel
approved these changes
May 31, 2023
yantosca
added a commit
that referenced
this pull request
Jun 1, 2023
benchmark/1mo_benchmark.yml benchmark/1yr_ch4_benchmark.yml benchmark/1yr_fullchem_benchmark.yml benchmark/1yr_tt_benchmark.yml benchmark/cloud/template.1hr_benchmark.yml benchmark/cloud/template.1mo_benchmark.yml - Removed "gcpy_test: False" from benchmark YAML config files. This should have been done in PR #222, but was somehow skipped. Signed-off-by: Bob Yantosca <[email protected]>
This was referenced Jun 1, 2023
hannahnesser
pushed a commit
to hannahnesser/gcpy
that referenced
this pull request
Jan 22, 2024
benchmark/1mo_benchmark.yml benchmark/1yr_ch4_benchmark.yml benchmark/1yr_fullchem_benchmark.yml benchmark/1yr_tt_benchmark.yml benchmark/cloud/template.1hr_benchmark.yml benchmark/cloud/template.1mo_benchmark.yml - Removed "gcpy_test: False" from benchmark YAML config files. This should have been done in PR geoschem#222, but was somehow skipped. Signed-off-by: Bob Yantosca <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This is the the companion PR to issue #220. It does the following:
gcpy_test_datapath from benchmark configuration files. This has now been replaced with placeholder text.ifblock that set the benchmark results paths when thegcpy_testdata was used.gcpy_testfrom the benchmarking routinesis_pre_13_1tags from benchmark configuration files.gchp_is_pre_13_1arguments from theget_filenameandget_filenamesfunctions ingcpy/util.pyExpected results
No differences are expected.