Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE REQUEST] Remove is_legacy option form GCpy benchmark scripts #144

Closed
laestrada opened this issue Mar 29, 2022 · 2 comments
Closed

[FEATURE REQUEST] Remove is_legacy option form GCpy benchmark scripts #144

laestrada opened this issue Mar 29, 2022 · 2 comments
Labels
category: Feature Request New feature or request topic: Benchmark Plots and Tables Issues pertaining to generating plots/tables from benchmark output

Comments

@laestrada
Copy link
Contributor

After version 14.0 is released we plan to deprecate the is_legacy option from GCpy.
@laestrada laestrada added the category: Feature Request New feature or request label Mar 29, 2022
@lizziel
Copy link
Contributor

lizziel commented Mar 30, 2022

The is_legacy option is a logical switch used in benchmarking code to indicate if GCHP files were generated before 13.1. If set to true then the old GCHP diagnostic file format containing the string "GCHP" is used. Otherwise the new format introduced in 13.1 is used. This format contains the string "GEOSChem" rather than "GCHP" and matches GC-Classic diagnostic filenames.

@yantosca yantosca added the topic: Benchmark Plots and Tables Issues pertaining to generating plots/tables from benchmark output label Aug 30, 2022
@yantosca
Copy link
Contributor

yantosca commented Jun 1, 2023

I think this has now been removed from the code. Also is_pre_13.1 has since been removed in PR #222. We can close this out.

@yantosca yantosca closed this as completed Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
category: Feature Request New feature or request topic: Benchmark Plots and Tables Issues pertaining to generating plots/tables from benchmark output
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lizziel @yantosca @laestrada