Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in GCHP transport tracer budget table #192

Merged
merged 1 commit into from
Jan 24, 2023

Conversation

lizziel
Copy link
Contributor

@lizziel lizziel commented Jan 10, 2023

This pull request fixes a bug reported by @1Dandan in which GCHP transport tracers budget source is incorrect because the emissions diagnostic is not flipped. All emission diagnostics output by GCHP in versions 14 and prior have level 1 correspond to top-of-atmosphere.

closes #185

@lizziel lizziel added category: Bug Something isn't working topic: Benchmark Plots and Tables Issues pertaining to generating plots/tables from benchmark output labels Jan 10, 2023
@lizziel lizziel requested a review from yantosca January 10, 2023 16:56
@lizziel lizziel self-assigned this Jan 10, 2023
@lizziel lizziel changed the title Fix bug where GCHP emissions levels not flipped in transport tracer b… Fix bug in GCHP transport tracer budget table Jan 10, 2023
Copy link
Contributor

@yantosca yantosca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lizziel: Looks good but I'm not sure about the kf equation.

gcpy/budget_tt.py Outdated Show resolved Hide resolved
@lizziel lizziel force-pushed the bugfix/gchp_transport_tracers_budget_source branch from 60091f2 to 789d5b4 Compare January 10, 2023 18:04
Copy link
Contributor

@yantosca yantosca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@yantosca yantosca merged commit eed8bcb into dev Jan 24, 2023
@lizziel lizziel added this to the 1.4.0 milestone Jan 31, 2023
@yantosca yantosca modified the milestones: 1.4.0, 1.3.3 Mar 9, 2023
@msulprizio msulprizio deleted the bugfix/gchp_transport_tracers_budget_source branch August 1, 2023 15:12
@yantosca yantosca added category: Bug Fix Fixes a bug that was previously reported and removed category: Bug Something isn't working labels Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: Bug Fix Fixes a bug that was previously reported topic: Benchmark Plots and Tables Issues pertaining to generating plots/tables from benchmark output
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants