Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG/ISSUE] Filp vertical dimention for the calculation of GCHP transport tracer budget in gcpy? #185

Closed
1Dandan opened this issue Dec 8, 2022 · 4 comments
Assignees
Labels
category: Bug Something isn't working
Milestone

Comments

@1Dandan
Copy link

1Dandan commented Dec 8, 2022

What institution are you from?

Washington University in St. Louis

Description of the problem

I just noticed a small bug in the calculation of GCHP transport tracer budget table in https://github.com/geoschem/gcpy/blob/main/gcpy/budget_tt.py
It looks like the emissions diagnostics in GCHP transport tracer should be flipped (surface layer at 72nd layer), which is not reflected in the calculation of the budget table.

It will only affect the source flux in the table. As a result, the source in GCC for Be7 is around 0.11 g/d, while that in GCHP is only 0.045 g/d .

I tested flipping the vertical dimension can get the source flux comparable with GCC, so hopefully it is the reason.

@1Dandan 1Dandan added the category: Bug Something isn't working label Dec 8, 2022
@msulprizio msulprizio transferred this issue from geoschem/GCHP Dec 8, 2022
@msulprizio
Copy link
Contributor

Thanks for reporting this @1Dandan. I have transferred the issue to the gcpy repository since it is an issue with the code there. We will try to address this soon.

@stale
Copy link

stale bot commented Jan 10, 2023

This issue has been automatically marked as stale because it has not had recent activity. If there are no updates within 7 days it will be closed. You can add the "never stale" tag to prevent the Stale bot from closing this issue.

@stale stale bot added the stale No recent activity on this issue label Jan 10, 2023
@lizziel
Copy link
Contributor

lizziel commented Jan 10, 2023

I put a fix in for this in #192. @1Dandan, could you look at those changes and verify they are correspond to your fix?

@stale stale bot removed the stale No recent activity on this issue label Jan 10, 2023
@lizziel lizziel self-assigned this Jan 10, 2023
@lizziel lizziel added this to the 1.4.0 milestone Jan 31, 2023
@lizziel
Copy link
Contributor

lizziel commented Jan 31, 2023

This update has been merged.

@lizziel lizziel closed this as completed Jan 31, 2023
@yantosca yantosca modified the milestones: 1.4.0, 1.3.3 Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants