Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GCClassic 14.5.1 release #80

Merged
merged 37 commits into from
Jan 10, 2025
Merged

GCClassic 14.5.1 release #80

merged 37 commits into from
Jan 10, 2025

Conversation

yantosca
Copy link
Contributor

Name and Institution (Required)

Name: Bob Yantosca
Institution: Harvard + GCST

Describe the update

This PR seeks to merge the release/14.5.1 branch into main in anticipation of the GCClassic 14.5.1 release.

The release/14.5.1 branch contains

  • Commits from the dev/no-diff-to-benchmark
  • ReadTheDoc updates for GCClassic 14.5.1
  • Updated version numbers to 14.5.1 in the usual places.

Expected changes

This is a no-diff-to-benchmark update

Tagging @msulprizio @lizziel

yantosca and others added 30 commits November 8, 2024 13:19
This merge brings in the updates from the 14.5.0 release back
into the dev/no-diff-to-benchmark branch.

See the CHANGELOG.md for updates.

Signed-off-by: Bob Yantosca <[email protected]>
This commit informs the GCClassic superproject about the following
commits that were pushed to the GitHub geoschem/geos-chem repository:

af83cf8ca Merge PR # (Allow upcase logfile name in download_data.py)
f149b460d Merge PR #2560 (Fix trace metals sim name in config files)

These PRs add minor zero-diff fixes.

Signed-off-by: Bob Yantosca <[email protected]>
This commit informs the GCClassic superproject about the following
commits that were pushed to the GitHub geoschem/geos-chem repository:

67ce84a59 Merge PR #2532 (Add allocate guards in pressure_mod)

This PR adds checks to make sure that we do not allocate
arrays that are already allocated.

Signed-off-by: Bob Yantosca <[email protected]>
This commit informs the GCClassic superproject about the following
commits that were pushed to the GitHub geoschem/geos-chem repository:

cad65f085 Merge PR #2544 (Fixes for SatDiagn diagnostic counters)

This PR fixes adds fixes to prevent the counters for the
SatDiagn and SatDiagnEdge diagnostic collections from being
inadvertently reset to zero.  This had caused diagnostic fields
to be steadily decreasing with time.

Signed-off-by: Bob Yantosca <[email protected]>
This commit informs the GCClassic superproject about the following
commits that were pushed to the GitHub geoschem/geos-chem repository:

135bdaaf3 Merge PR #2580 (Remove duplicate WD_RetFactor for HgClHO2)

This PR removes a duplicated YAML tag in species_database.yml.

Signed-off-by: Bob Yantosca <[email protected]>
This commit informs the GCClassic superproject about the following
commits that were pushed to the GitHub geoschem/geos-chem repository:

7507eb590 Merge PR #2486 (Prevent seg fault in qfyaml)

This PR fixes a seg fault that occurs in Headers/qfyaml_mod.F90
with certain compilers (such as Intel 2022.2.1)

Signed-off-by: Bob Yantosca <[email protected]>
This commit informs the GCClassic superproject about the following
commits that were pushed to the GitHub geoschem/geos-chem repository:

e2157dc98 Merge PR #2542 (CESM fix: exclude hard dependencies on HEMCO)

This PR fixes build issues when compiling GEOS-Chem in CESM.

Signed-off-by: Bob Yantosca <[email protected]>
This commit informs the GCClassic superproject about the following
commits that were pushed to the GitHub geoschem/geos-chem repository:

62f3db08b Merge PR #2578 (Fixes to compile GCHP adjoint)

This PR fixes several compilation issues when building the
GCHP adjoint.  It does not affect "forward" GEOS-Chem Classic
or GCHP simulations.

Signed-off-by: Bob Yantosca <[email protected]>
src/CMakeLists.txt
- Add CMake commands to define the KPP executable file, where it
  should be installed, and what it depends on.

CHANGELOG.md
- Updated accordingly

Signed-off-by: Bob Yantosca <[email protected]>
src/CMakeLists.txt
- Added install command to place the kpp_standalone executable
  file in the run directory

Signed-off-by: Bob Yantosca <[email protected]>
This commit informs the GCClassic superproject about the following
commits that were pushed to the GitHub geoschem/geos-chem repository:

4a10fac7e Merge PR #2593 (Prevent duration < frequency in History diags)

This PR fixes an issue where empty diagnostic files could be
created if the collection duration setting was less than
the frequency setting.  Now an error will be thrown and the
run will halt.

Signed-off-by: Bob Yantosca <[email protected]>
This merge brings PR #2588 (Add KPP Standalone into GEOS-Chem 14.5.1,
by @yantosca and @obin1) into the GEOS-Chem "no-diff-to-benchmark"
development stream.

This PR does the following:

1. Adds an interface to save out the model state for input into the
   KPP Standalone box model

2. Adds the https://github.com/KineticPreProcessor/KPP-Standalone
   repo as a Git submodule.

Signed-off-by: Bob Yantosca <[email protected]>
This merge brings PR #73 (Add KPP standalone into 14.5.1,
by @yantosca and @obin1) into the GCClassic "no-diff-to-benchmark"
development stream.

This PR adds code to src/CMakeLists.txt so that the KPP standalone
executable will be built if the fullchem or custom mechanism
is chosen.

Signed-off-by: Bob Yantosca <[email protected]>
Submodule src/GEOS-Chem a4e36e9..ed893d0:
  > Merge pull request #2608 from geoschem/bugfix/tagged_CO_restart

Submodule src/HEMCO deaa192..d00af43:
  > Merge pull request #296 from geoschem/bugfix/reduce_hemco_read_prints_in_mpi

Signed-off-by: Lizzie Lundgren <[email protected]>
Submodule src/GEOS-Chem ed893d0..990e8e4:
  > Merge pull request #2612 from geoschem/bugfix/typo_in_tagco_restart_date

Signed-off-by: Lizzie Lundgren <[email protected]>
.ci-pipelines/build-matrix.yml
.ci-pipelines/quick-build.yml
- Changed "submodules: true" to "submodules: recursive" so that all
  levels of submodules will be fetched when cloning GEOS-Chem code
  in the continuous integration tests.

CHANGELOG.md
- Updated accordingly

Signed-off-by: Bob Yantosca <[email protected]>
Fix configuration error in GEOS-Chem Classic continuous integration tests on Azure
Submodule src/GEOS-Chem be335b7..990e8e4 (rewind):
  < Merge pull request #2553 from geoschem/bugfix/geos
  < Merge pull request #2523 from
    yuanjianz/bugfix/Grell_Friedas_convection

Signed-off-by: Lizzie Lundgren <[email protected]>
Submodule src/GEOS-Chem be335b7..1a09d12:
  > Merge pull request #2615 from geoschem/bugfix/
    gchp_integration_test_issue_from_rundir_creation_message_change

Signed-off-by: Lizzie Lundgren <[email protected]>
This commit informs the GCClassic superproject about the following
commits that were pushed to the GitHub geoschem/geos-chem repository:

29f6c72c4 Merge PR #2617 (KPP standalone submodule update)

This PR updates the KPP/standalone submodule hash to point to
a bug fix (write KPP standalone output with 3-digit exponents,
to avoid corrupted output).

Signed-off-by: Bob Yantosca <[email protected]>
docs/source/geos-chem-shared-docs
- Submodule update: Added KPP-Standalone Supplemental Guide (bc4d75c)

docs/source/index.rst
- Added KPP-Standalone Supplemental Guide to toctree

CHANGELOG.md
- Updated accordingly

Signed-off-by: Bob Yantosca <[email protected]>
Fix CH4 livestock emissions hotspots and seasonality by reverting to EDGARv7 livestock emissions

Signed-off-by: Melissa Sulprizio <[email protected]>
This commit informs the GCClassic superproject about the following
commits that were pushed to the GitHub geoschem/geos-chem repository:

20a93f331 Merge PR #2634 (Add sonde sites to kpp_standalone_interface.yml )

This PR updates the kpp_standalone_interface.yml file that is
placed into rundirs using either fullchem and custom simulations.
Extra "active cells" (sites to write output) have been added.

Signed-off-by: Bob Yantosca <[email protected]>
src/CMakeLists.txt
- Defined the KPPSA_FILE_NAME variable for all mechanisms
- Call "add_executable(KPPSA_FILE_NAME ...) for all mechanisms
- Added an else block to disable the KPPSA_FILE_NAME executable
  from being built except for fullchem & custom mechanisms
- Wrapped the installation command for the KPPSA_FILE_NAME executable
  in an if block to ensure it is only built for fullchem & custom
  mechanisms.

CHANGELOG.md
- Updated accordingly

Signed-off-by: Bob Yantosca <[email protected]>
This merge brings PR #79 (Fixed error in CMake logic that
attempted to build the KPP standalone for mechanisms other
than fullchem and custom, by @yantosca) into the GEOS-Chem
"no-diff-to-benchmark" development stream.

This PR fixes a build issue that can occur when the CMake
commands are given separately instead of as a single command.
See issue #78 for details.

Signed-off-by: Bob Yantosca <[email protected]>
docs/source/geos-chem-shared-docs
- Submodule update to 4fc0461 (kpp_standalone_interface.yml update)

docs/source/getting_started/login-env-parallel.rst
- Fixed broken link to "Segmentation fault after TPCORE initialization"
  section in the "Understand error messages and what they mean"
  supplemental guide.

CHANGELOG.md
- Updated accordingly

Signed-off-by: Bob Yantosca <[email protected]>
Submodule src/GEOS-Chem 20a93f3..9c352ab:
  > Merge pull request #2642 from geoschem/bugfix/cesm_fixes
  > Merge pull request #2643 from geoschem/feature/clean_up_hemco_log_and_error_handling

Submodule src/HEMCO d00af43..c76adbb:
  > Merge pull request #298 from geoschem/feature/improve_log_flexibility_in_hemco

Signed-off-by: Lizzie Lundgren <[email protected]>
This commit informs the GCClassic superproject about the following
commits that were pushed to the GitHub geoschem/geos-chem repository:

18712bb Add extra examples to supplemental-guides/error-guide.rst

This update adds documentation for additional common errors to the
"Understanding what error messages mean" supplemental guide.

Signed-off-by: Bob Yantosca <[email protected]>
This commit informs the GCClassic superproject about the following
commits that were pushed to the GitHub geoschem/geos-chem repository:

f43e771fa Merge PR #2669 (Implement Australian Hg emissions)

This PR implements a new emissions inventory for the Hg simulation,
based on MacFarlane et al. [2022].

Signed-off-by: Bob Yantosca <[email protected]>
yantosca and others added 7 commits January 7, 2025 14:05
This commit informs the GCClassic superproject about the following
commits that were pushed to the GitHub geoschem/geos-chem repository:

3de2b85f6 Merge PR #2670 (Warn users not to change BC freq in HISTORY.rc)

This PR adds a warning to the HISTORY.rc template files.

Signed-off-by: Bob Yantosca <[email protected]>
This commit informs the GCClassic superproject about the following
commits that were pushed to the GitHub geoschem/geos-chem repository:

ab77f5279 Merge PR #2674 (Harvard Cannon int test now use GNU12 compilers)

This PR changes the default compiler used by integration tests on
Harvard Cannon from GCC 10.2.0 to GCC 12.2.0.

Signed-off-by: Bob Yantosca <[email protected]>
This commit informs the GCClassicsuperproject about the following
commits that were pushed to the GitHub geoschem/geos-chem repository:

48358bc0a Merge PR #2675 (Bugfix for GCHP to read meteorology from YAML)

According to @lizziel:

  I believe this fixes an issue brought in with the updates for
  GEOS-IT in dev/no-diff-to-benchmark (see PR #2523). It would only
  show up for GEOS-FP and GEOS-IT runs which we do not test in
  integration/AWS testing, and is not in any previously released
  versions. It therefore does not need an update to the changelog.

Signed-off-by: Bob Yantosca <[email protected]>
This merge brings the commits from the "no-diff-to-benchmark" development
stream into the release/14.5.1 branch, in anticipation of the GCClassic
14.5.1 release.

Signed-off-by: Bob Yantosca <[email protected]>
This merge brings ReadTheDocs updates for GEOS-Chem 14.5.1 into
the release/14.5.1 branch, in anticipation of the 14.5.1 release.

Signed-off-by: Bob Yantosca <[email protected]>
This is the official release commit of GEOS-Chem Classic
aka GCClassic) 14.5.1.

Updated version numbers in:
- CHANGELOG.md
- CMakeLists.txt
- docs/source/conf.py

Updated GEOS-Chem submodule to version 14.5.1

Updated HEMCO submodule to version 3.10.1

Updated geos-chem-shared-docs submodule to commit 18712bb

Also updated CHANGELOG.md with the latest information.

Signed-off-by: Bob Yantosca <[email protected]>
@yantosca yantosca added the category: Feature Request New feature or request label Jan 10, 2025
@yantosca yantosca requested a review from lizziel January 10, 2025 18:58
@yantosca yantosca self-assigned this Jan 10, 2025
@yantosca yantosca merged commit 9c964c8 into main Jan 10, 2025
3 checks passed
@yantosca yantosca deleted the release/14.5.1 branch January 10, 2025 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: Feature Request New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants