Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix configuration error in GEOS-Chem Classic continuous integration tests on Azure #77

Merged
merged 1 commit into from
Dec 5, 2024
Merged

Fix configuration error in GEOS-Chem Classic continuous integration tests on Azure #77

merged 1 commit into from
Dec 5, 2024

Conversation

yantosca
Copy link
Contributor

@yantosca yantosca commented Dec 5, 2024 •
edited
Loading

Name and Institution (Required)

Name: Bob Yantosca
Institution: Harvard + GCST

Describe the update

This PR resolves the following error:

=================================================================
GEOS-Chem 14.5.0 (science codebase)
Current status: 14.6.0-alpha.0-84-g990e8e408
=================================================================
CMake Error at src/GEOS-Chem/KPP/CMakeLists.txt:9 (add_subdirectory):
  The source directory

    /__w/1/s/src/GEOS-Chem/KPP/standalone

  does not contain a CMakeLists.txt file.


Creating /__w/1/s/src/GEOS-Chem/Interfaces/GCClassic/gc_classic_version.H
-- Configuring incomplete, errors occurred!
See also "/__w/1/s/build/CMakeFiles/CMakeOutput.log".
+ make -j
make: *** No targets specified and no makefile found.  Stop.

in GEOS-Chem Classic continuous integration tests on Azure Dev Pipelines.

This error was introduced when the https://geos-chem/geoschem/KPP-Standalone repo was introduced as a submodule to the GEOS-Chem Science Codebase, The solution is to edit the configuration files in the ./ci-pipelines folder to specify recursive submodule fetching by changing:

# Try building GEOS-Chem
steps:
- checkout: self
  submodules: true

to

# Try building GEOS-Chem
steps:
- checkout: self
  submodules: recursive

Expected changes

With this fix, Azure continuous integration tests for GEOS-Chem Classic should run to completion.

Related Github Issue

The KPP standalone was introduced into GEOS-Chem Classic in these PRs:

@yantosca
Bug fix" Now use "submodules: recursive" in Azure config files
dc666fc 
.ci-pipelines/build-matrix.yml
.ci-pipelines/quick-build.yml
- Changed "submodules: true" to "submodules: recursive" so that all
  levels of submodules will be fetched when cloning GEOS-Chem code
  in the continuous integration tests.

CHANGELOG.md
- Updated accordingly

Signed-off-by: Bob Yantosca <[email protected]>
@yantosca yantosca added no-diff-to-benchmark This update will not change the results of fullchem benchmark simulations topic: Benchmarking and Testing Related to CI, integration tests, or scientific benchmarking category: Bug Fix Fixes a bug that was previously reported labels Dec 5, 2024
@yantosca yantosca added this to the 14.5.1 milestone Dec 5, 2024
@yantosca yantosca requested a review from lizziel December 5, 2024 17:05
@yantosca yantosca self-assigned this Dec 5, 2024
@yantosca
Copy link
Contributor Author

yantosca commented Dec 5, 2024

@lizziel: The fix is confirmed:

pipelines

@lizziel lizziel merged commit b474570 into dev/no-diff-to-benchmark Dec 5, 2024
4 checks passed
@yantosca yantosca deleted the bugfix/azure-pipelines branch December 6, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lizziel lizziel lizziel approved these changes

Assignees

@yantosca yantosca

Labels
category: Bug Fix Fixes a bug that was previously reported no-diff-to-benchmark This update will not change the results of fullchem benchmark simulations topic: Benchmarking and Testing Related to CI, integration tests, or scientific benchmarking
Projects
None yet
Milestone
14.5.1
Development

Successfully merging this pull request may close these issues.
2 participants
@yantosca @lizziel