Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scale value to avoid nullity #699

Merged
merged 2 commits into from
Nov 27, 2023
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix: Update changedetection strategy to avoid undefinite calls to get…
…ters
f-necas committed Nov 27, 2023
commit 248d26df308b109589c4cf984b0c3000ac30c3b7
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import {
AfterViewInit,
ChangeDetectionStrategy,
ChangeDetectorRef,
Component,
Input,
@@ -67,6 +68,7 @@ export const MY_FORMATS = {
},
{ provide: MAT_DATE_FORMATS, useValue: MY_FORMATS },
],
changeDetection: ChangeDetectionStrategy.OnPush,
})
export class WizardFieldComponent implements AfterViewInit, OnDestroy {
@Input() wizardFieldConfig: WizardFieldModel
@@ -104,7 +106,6 @@ export class WizardFieldComponent implements AfterViewInit, OnDestroy {
return data ? new Date(Number(data)) : new Date()
}
case WizardFieldType.DROPDOWN: {
//TODO called continuously
return data ? JSON.parse(data) : this.dropdownChoices[0]?.value
}
}