Fix scale value to avoid nullity #699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Affected libs:
|
jahow
approved these changes
Nov 22, 2023
| @@ -103,15 +104,20 @@ export class WizardFieldComponent implements AfterViewInit, OnDestroy { | |||
| return data ? new Date(Number(data)) : new Date() | |||
| } | |||
| case WizardFieldType.DROPDOWN: { | |||
| //TODO called continuously | |||
There was a problem hiding this comment.
Could you maybe make that clearer? does that mean that this code is executed a lot and that it's undesirable?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Datafeeder Scale fix
In order to avoid a
nullvalue sent to the server while a default value is the present in the UI.This PR fixes the next issue :
❗ Also fix an error in the console mentioning that 'BrowserAnimationsModule' wasn't present.