Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to plain mongo image #91

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

nr23730
Copy link
Contributor

@nr23730 nr23730 commented Aug 12, 2024

This change migrates the mongo image from bitnami to the official mongo image from docker library.

Using that image should allow easier upgrades of mongo in the future.
In addition the official mongo image is available for multiple architecutres (including arm, which would allow the usage of AWS graviton nodes), while the bitnami one is only available on x86_64.

@inodb inodb requested a review from leexgh August 12, 2024 15:37
@nr23730
Copy link
Contributor Author

nr23730 commented Aug 12, 2024

For further explanation:

The init.sh file is a copy of the original entrypoint of the docker image (https://github.com/docker-library/mongo/blob/56dd5c86b7a329b944845ea782fb98a3384d8d4e/4.0/docker-entrypoint.sh) with one change:

Replacing the last line

exec "$@"

with

cp -r /data/db/ /seed

This makes the builder terminate instead of run mongod after the initialization and saves the data to a save place (otherwise they are being deleted).

scripts/init.sh Show resolved Hide resolved
Copy link
Member

@leexgh leexgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! @nr23730 Can I know how you spin up the database? We use this command to deploy database on kubernetes cluster (see doc):

helm install gn-mongo-v0dot31 bitnami/mongodb --version 7.3.1 --set image.repository=genomenexus/gn-mongo,image.tag=0.31_mutationassessor,persistence.size=100Gi,nodeSelector."eks\.amazonaws\.com/nodegroup"=eks-genome-nexus-database,tolerations[0].key="dedicated",tolerations[0].operator="Equal",tolerations[0].value="eks-genome-nexus-database",tolerations[0].effect="NoSchedule" --namespace genome-nexus

After using plain mongo image, can we still do it the same way?

@nr23730
Copy link
Contributor Author

nr23730 commented Aug 13, 2024

I'm sorry, but I haven't deployed it on kubernetes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants