Tracking of spike-like-event times #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Additional method for WeightUpdateModel * Additional NeuronGroup API to control location * Included variables in group merged * Backend support for updating
# Conflicts: # include/genn/genn/code_generator/codeGenUtils.h # include/genn/genn/neuronGroup.h # include/genn/genn/weightUpdateModels.h # src/genn/backends/cuda/optimiser.cc # src/genn/backends/single_threaded_cpu/backend.cc # src/genn/genn/code_generator/backendSIMT.cc # src/genn/genn/code_generator/generateInit.cc # src/genn/genn/code_generator/generateNeuronUpdate.cc # src/genn/genn/code_generator/generateRunner.cc # src/genn/genn/code_generator/groupMerged.cc # src/genn/genn/code_generator/modelSpecMerged.cc # src/genn/genn/neuronGroup.cc
…nal threshold check
…g pre-neuron reset groups
…RESHOLD is provided - times can still be used without event handler
Codecov Report
@@ Coverage Diff @@
## master #380 +/- ##
========================================
Coverage 86.57% 86.58%
========================================
Files 70 70
Lines 12785 12917 +132
========================================
+ Hits 11069 11184 +115
- Misses 1716 1733 +17
Continue to review full report at Codecov.
|
tnowotny
approved these changes
Dec 16, 2020
|
Thanks! The only problem relates to #379. |
…e multiple conditions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small extension of #376 to improve support for fully event-driven three-factor learning using spike-like events to deliver the third factor. By adding SET_NEEDS_PRE_SPIKE_EVENT_TIME(true) or SET_NEEDS_PREV_PRE_SPIKE_EVENT_TIME(true) macros to a weight update model in C++ or setting the is_pre_spike_event_time_required=True or is_prev_pre_spike_event_time_required=True kwargs in Python, the same sort of code used for tracking spike times is generated and
$(seT)and$(prev_seT)can be used from weight update model code.