Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repeat of spike-like-event conditions in synapse code flawed #379

Closed
neworderofjamie opened this issue Dec 1, 2020 · 0 comments
Closed
Labels
Milestone

Comments

@neworderofjamie
Copy link
Contributor

neworderofjamie commented Dec 1, 2020

In some cases e.g. "$(V_pre) > -50.0" this is likely to work but e.g. a condition that is only true before the spike reset code is run or one triggered using an extra global parameter will fail as the condition won't be true when it's re-checked next timestep (/after axonal delay) in the synapse code. There is also a much more minor issue that the threshold condition code is not considered when determining which neuron variables require queues in ModelSpec::finalize.

I think the best fix is for each spike-like-event condition (give or take some merging which is already done) to generate its own array of events.

@neworderofjamie neworderofjamie changed the title Repeat of spike-like-event conditions in weight update model flawed Repeat of spike-like-event conditions in synapse code flawed Dec 1, 2020
@neworderofjamie neworderofjamie added this to the GeNN 5.0.0 milestone Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant