-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add warnings and errors to ImpactsOutput
#99
Conversation
4db4e9b
to
861ecb1
Compare
Impacts
output ImpactsOutput
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @samuelrince for the nice PR! Much better like this
Just a small comment. Although I completely agree that spamming the user with the logger for the warnings is a bad idea, it still seems to me that the errors should be very easily spotable by the user. A first-time user could try EcoLogits, get nonsense values in ImpactsOutput
and miss the error.
--> To me, it should be crystal clear from the welcome page in ecologits.ai that the user has to check himself/herself the errors
Yes, I agree with you @adrienbanse, more documentation on the get started should be added! I'm thinking, maybe we can also consider showing warnings and errors in the console the first time they appear and then ignoring them. I'll try to improve this! |
4ad263c
to
1bf31bd
Compare
Ping @adrienbanse if you want to check the new changes on the logging system :) FYI I am working on an improved version of the documentation on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, thanks @samuelrince
For #59