Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement warnings #59

Closed
samuelrince opened this issue Jul 4, 2024 · 3 comments
Closed

Implement warnings #59

samuelrince opened this issue Jul 4, 2024 · 3 comments

Comments

@samuelrince
Copy link
Member

Description

Display warnings in the impacts section of each response when needed. These warnings can inform the user on the quality of the estimation for closed-source models, for instance.

Solution

Some warnings are already defined in the models.csv file.

@adrienbanse
Copy link
Member

@samuelrince As an attribute of Impacts? We could also simply use logger.warning, or both

@samuelrince
Copy link
Member Author

samuelrince commented Sep 12, 2024

As an attribute of Impacts, because logging it would also be very spammy. I'd like to finish the new structure of model repository before adding the feature though ;)

logging.warning must be used to notify that the user must do an action. For example, if we deprecate mistral v0 for v1 we need to warn users before that the package version will no longer be supported in EcoLogits v0.x

@adrienbanse
Copy link
Member

@samuelrince This is closed right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants