Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address fields are not required on the partner form #2388

Merged
merged 4 commits into from
Apr 15, 2024

Conversation

aaaaargZombies
Copy link
Contributor

fixes #2310

Notes

If someone misses out both these fields when adding the address, and they have a service area, it fails silently (refreshing the page but no warning). An unlikely event but it does not allow the creation of a malformed address.

There is a related issue #2364 that is outside the scope of the PR

@aaaaargZombies aaaaargZombies requested a review from a team April 11, 2024 15:41
@aaaaargZombies aaaaargZombies changed the title These fields are not required on the partner form Address fields are not required on the partner form Apr 11, 2024
Copy link
Contributor

@r-ferrier r-ferrier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is more helpful even with the silent fail possibility, but maybe add this into the other issue so it's more of a 'fix validation in general' kind of ticket? I feel like a flash should tell you at least that an address has not been saved.

@aaaaargZombies
Copy link
Contributor Author

OK will merge this as is and have opened this issue #2391 so we can decide where it sits compared to our other priorities.

@aaaaargZombies aaaaargZombies merged commit 7def675 into main Apr 15, 2024
2 checks passed
@aaaaargZombies aaaaargZombies deleted the 2310-address-astrix branch April 15, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: It is not clear when creating a partner that you can make one with just a service area
2 participants