Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make place requirements clearer on partner forms #2317

Merged

Conversation

aaaaargZombies
Copy link
Contributor

@aaaaargZombies aaaaargZombies commented Mar 18, 2024

fixes #2310

I've moved the place based parts of the form together and added text explaining that one is required. Updated with honor's description for people using the admin UI. Hopefully this makes it a bit clearer.

image

@honor-gfsc
Copy link

I would suggest something like:

Partners need to be associated with at least one place. This can be a fixed address if they usually operate from one location, or a service area which can be a Ward or District. Keep this information as specific as possible – limited to where this partner actually runs events rather than the geographical spread of the people they are trying to reach.

This is probably a bit long and maybe the explanation is too much but we can edit down.

@aaaaargZombies aaaaargZombies force-pushed the 2310-make-place-requirements-clearer-for-partners branch from 7d35649 to f3f5783 Compare March 19, 2024 11:46
@aaaaargZombies aaaaargZombies marked this pull request as ready for review March 19, 2024 11:50
@aaaaargZombies aaaaargZombies requested a review from a team March 19, 2024 13:04
Copy link
Contributor

@ivan-kocienski-gfsc ivan-kocienski-gfsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a sensible layout, let's hope it is easier to intuit for all users

@aaaaargZombies aaaaargZombies merged commit 4887962 into main Mar 21, 2024
2 checks passed
@aaaaargZombies aaaaargZombies deleted the 2310-make-place-requirements-clearer-for-partners branch March 21, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: It is not clear when creating a partner that you can make one with just a service area
3 participants