Feature: Not Found page #1496
Merged
Feature: Not Found page #1496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will this also fix #1408? Looks good to me tho! (Will let F sign it off). Can't believe this is was issue all along, lol. |
|
Unfortunately not. Assets are served outside of the app so only missing resources will get covered by this fix |
ivan-kocienski-gfsc
force-pushed
the
ik-1407-record-not-found
branch
from
aaa2276 to
cbcf04d
Compare
aaaaargZombies
approved these changes
Oct 25, 2022
|
Confirmed working but only for events - will open new tickets for other errors
|
|
Ah its here already: #759 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1407
When an ActiveRecord resource can't be located, show a user friendly page.